From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Subject: Re: [PATCH 1/2] i2c: Add support for device alias names Date: Mon, 28 Apr 2008 17:07:25 +0200 Message-ID: <1209395245.3666.9.camel@linux.site> References: <20080428113052.6d024bda@hyperion.delvare> <20080428113901.2772e9d9@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20080428113901.2772e9d9@hyperion.delvare> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Jean Delvare Cc: linuxppc-dev list , Paul Mundt , Scott Wood , Linux I2C List-Id: linux-i2c@vger.kernel.org T24gTW9uLCAyMDA4LTA0LTI4IGF0IDExOjM5ICswMjAwLCBKZWFuIERlbHZhcmUgd3JvdGU6Cj4g QmFzZWQgb24gZWFybGllciB3b3JrIGJ5IEpvbiBTbWlybCBhbmQgSm9jaGVuIEZyaWVkcmljaC4K PiAKPiBUaGlzIHBhdGNoIGFsbG93cyBuZXctc3R5bGUgaTJjIGNoaXAgZHJpdmVycyB0byBoYXZl IGFsaWFzIG5hbWVzIHVzaW5nCj4gdGhlIG9mZmljaWFsIGtlcm5lbCBhbGlhc2luZyBzeXN0ZW0g YW5kIE1PRFVMRV9ERVZJQ0VfVEFCTEUoKS4gQXQgdGhpcwo+IHBvaW50LCB0aGUgb2xkIGkyYyBk cml2ZXIgYmluZGluZyBzY2hlbWUgKGRyaXZlcl9uYW1lL3R5cGUpIGlzIHN0aWxsCj4gc3VwcG9y dGVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEplYW4gRGVsdmFyZSA8a2hhbGlAbGludXgtZnIub3Jn Pgo+IENjOiBKb2NoZW4gRnJpZWRyaWNoIDxqb2NoZW5Ac2NyYW0uZGU+Cj4gQ2M6IEpvbiBTbWly bCA8am9uc21pcmxAZ21haWwuY29tPgo+IENjOiBLYXkgU2lldmVycyA8a2F5LnNpZXZlcnNAdnJm eS5vcmc+Cj4gLS0tCj4gT25lIHRoaW5nIEkgYW0gc3RpbGwgbm90IGhhcHB5IHdpdGggaXMgdGhh dCB0aGUgYWxpYXNlcyBjcmVhdGVkIGhhdmUgYQo+IHRyYWlsaW5nICIqIjoKPiAKPiAkIC9zYmlu L21vZGluZm8gbG05MAo+IGZpbGVuYW1lOiAgICAgICAvbGliL21vZHVsZXMvMi42LjI1LWdpdDEx L2tlcm5lbC9kcml2ZXJzL2h3bW9uL2xtOTAua28KPiBhdXRob3I6ICAgICAgICAgSmVhbiBEZWx2 YXJlIDxraGFsaUBsaW51eC1mci5vcmc+Cj4gZGVzY3JpcHRpb246ICAgIExNOTAvQURNMTAzMiBk cml2ZXIKPiBsaWNlbnNlOiAgICAgICAgR1BMCj4gdmVybWFnaWM6ICAgICAgIDIuNi4yNS1naXQx MSBtb2RfdW5sb2FkCj4gZGVwZW5kczogICAgICAgIGh3bW9uCj4gYWxpYXM6ICAgICAgICAgIGky YzpsbTkwKgo+IGFsaWFzOiAgICAgICAgICBpMmM6YWRtMTAzMioKPiBhbGlhczogICAgICAgICAg aTJjOmxtOTkqCj4gYWxpYXM6ICAgICAgICAgIGkyYzpsbTg2Kgo+IGFsaWFzOiAgICAgICAgICBp MmM6bWF4NjY1NyoKPiBhbGlhczogICAgICAgICAgaTJjOmFkdDc0NjEqCj4gYWxpYXM6ICAgICAg ICAgIGkyYzptYXg2NjgwKgo+ICQKPiAKPiBUaGlzIHdvdWxkIGNhdXNlIHRyb3VibGUgaWYgb25l IEkyQyBjaGlwIG5hbWUgbWF0Y2hlcyB0aGUgYmVnaW5uaW5nIG9mCj4gYW5vdGhlciBJMkMgY2hp cCBuYW1lIGFuZCBib3RoIGNoaXBzIGFyZSBzdXBwb3J0ZWQgYnkgZGlmZmVyZW50Cj4gZHJpdmVy cy4gVGhpcyBoYXMgeWV0IHRvIGJlIHNlZW4sIGJ1dCBzdGlsbCwgSSdkIGxpa2UgdG8gc2VlIHRo aXMKPiBwcm9ibGVtIGZpeGVkIHF1aWNrbHkuCgrvu79SaWdodCwgdGhlIHRyYWlsaW5nICIqIiBp cyBub3QgbmljZS4KCldlIHNob3VsZCB0ZXJtaW5hdGUgdGhlIHN0cmluZywgc28gdGhlIHRyYWls aW5nICIqIiB3aWxsIG5vdCBtYXRjaApsb25nZXIgc3RyaW5ncy4gVGhlIHVzdWFsIHRoaW5nIGlz IHRvIGFkZCBhICI6IiB0byB0aGUgZW5kLCB3aGljaCB3b3VsZAp0aGVuIHNob3cgdXAgYXMKICBh bGlhczogaTJjOm1heDY2ODA6KgoKU2VlIERNSSBhbmQgQUNQSToKICBhbGlhcyBkbWk6Kjpzdm5G VUpJVFNVOnBuTGlmZUJvb2sqOnB2cio6cnZuRlVKSVRTVToqIGFwYW5lbAogIGFsaWFzIGFjcGkq OkFTSU0wMDAwOiogYXRsYXNfYnRucwoKSWYgaTJjIGRldmljZSBtb2RhbGlhc2VzIGNvdWxkIGV2 ZXIgY29udGFpbiBtdWx0aXBsZSBzdHJpbmdzLCBpdCBzaG91bGQKYmU6CiAgYWxpYXM6IGkyYyo6 bWF4NjY4MDoqCu+7v3RvIG1hdGNoIHRoZSBtb2R1bGUsIHJlZ2FyZGxlc3Mgb2YgdGhlIG9yZGVy IG9mIHRoZSBzdHJpbmdzIGluIHRoZQptb2RhbGlhczoKClRoYW5rcywKS2F5CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eHBwYy1kZXYgbWFpbGlu ZyBsaXN0CkxpbnV4cHBjLWRldkBvemxhYnMub3JnCmh0dHBzOi8vb3psYWJzLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4cHBjLWRldg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.177]) by ozlabs.org (Postfix) with ESMTP id 2A157DDE16 for ; Tue, 29 Apr 2008 01:09:13 +1000 (EST) Subject: Re: [PATCH 1/2] i2c: Add support for device alias names From: Kay Sievers To: Jean Delvare In-Reply-To: <20080428113901.2772e9d9@hyperion.delvare> References: <20080428113052.6d024bda@hyperion.delvare> <20080428113901.2772e9d9@hyperion.delvare> Content-Type: text/plain; charset=utf-8 Date: Mon, 28 Apr 2008 17:07:25 +0200 Message-Id: <1209395245.3666.9.camel@linux.site> Mime-Version: 1.0 Cc: linuxppc-dev list , Paul Mundt , Scott Wood , Linux I2C List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2008-04-28 at 11:39 +0200, Jean Delvare wrote: > Based on earlier work by Jon Smirl and Jochen Friedrich. >=20 > This patch allows new-style i2c chip drivers to have alias names using > the official kernel aliasing system and MODULE_DEVICE_TABLE(). At this > point, the old i2c driver binding scheme (driver_name/type) is still > supported. >=20 > Signed-off-by: Jean Delvare > Cc: Jochen Friedrich > Cc: Jon Smirl > Cc: Kay Sievers > --- > One thing I am still not happy with is that the aliases created have a > trailing "*": >=20 > $ /sbin/modinfo lm90 > filename: /lib/modules/2.6.25-git11/kernel/drivers/hwmon/lm90.ko > author: Jean Delvare > description: LM90/ADM1032 driver > license: GPL > vermagic: 2.6.25-git11 mod_unload > depends: hwmon > alias: i2c:lm90* > alias: i2c:adm1032* > alias: i2c:lm99* > alias: i2c:lm86* > alias: i2c:max6657* > alias: i2c:adt7461* > alias: i2c:max6680* > $ >=20 > This would cause trouble if one I2C chip name matches the beginning of > another I2C chip name and both chips are supported by different > drivers. This has yet to be seen, but still, I'd like to see this > problem fixed quickly. =EF=BB=BFRight, the trailing "*" is not nice. We should terminate the string, so the trailing "*" will not match longer strings. The usual thing is to add a ":" to the end, which would then show up as alias: i2c:max6680:* See DMI and ACPI: alias dmi:*:svnFUJITSU:pnLifeBook*:pvr*:rvnFUJITSU:* apanel alias acpi*:ASIM0000:* atlas_btns If i2c device modaliases could ever contain multiple strings, it should be: alias: i2c*:max6680:* =EF=BB=BFto match the module, regardless of the order of the strings in the modalias: Thanks, Kay