diff for duplicates of <1209399377.3666.30.camel@linux.site> diff --git a/a/1.txt b/N1/1.txt index ff803ca..a8cb1fe 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,13 @@ On Mon, 2008-04-28 at 17:40 +0200, Jean Delvare wrote: > On Mon, 28 Apr 2008 17:07:25 +0200, Kay Sievers wrote: > > On Mon, 2008-04-28 at 11:39 +0200, Jean Delvare wrote: -> > > One thing I am still not happy with is that the aliases created have a +> > > One thing I am still not happy with is that the aliases created have = +a > > > trailing "*": -> > > +> > >=20 > > > $ /sbin/modinfo lm90 -> > > filename: /lib/modules/2.6.25-git11/kernel/drivers/hwmon/lm90.ko +> > > filename: /lib/modules/2.6.25-git11/kernel/drivers/hwmon/lm90.k= +o > > > author: Jean Delvare <khali@linux-fr.org> > > > description: LM90/ADM1032 driver > > > license: GPL @@ -19,32 +21,34 @@ On Mon, 2008-04-28 at 17:40 +0200, Jean Delvare wrote: > > > alias: i2c:adt7461* > > > alias: i2c:max6680* > > > $ -> > > -> > > This would cause trouble if one I2C chip name matches the beginning of +> > >=20 +> > > This would cause trouble if one I2C chip name matches the beginning o= +f > > > another I2C chip name and both chips are supported by different > > > drivers. This has yet to be seen, but still, I'd like to see this > > > problem fixed quickly. -> > -> > Right, the trailing "*" is not nice. -> > +> >=20 +> > =EF=BB=BFRight, the trailing "*" is not nice. +> >=20 > > We should terminate the string, so the trailing "*" will not match > > longer strings. The usual thing is to add a ":" to the end, which would > > then show up as > > alias: i2c:max6680:* -> > +> >=20 > > See DMI and ACPI: > > alias dmi:*:svnFUJITSU:pnLifeBook*:pvr*:rvnFUJITSU:* apanel > > alias acpi*:ASIM0000:* atlas_btns -> +>=20 > I didn't know about these cases, thanks for the hint. -> -> > +>=20 +> >=20 > > If i2c device modaliases could ever contain multiple strings, it should > > be: > > alias: i2c*:max6680:* -> > to match the module, regardless of the order of the strings in the +> > =EF=BB=BFto match the module, regardless of the order of the strings in= + the > > modalias: -> +>=20 > Why would i2c device modaliases ever contain multiple strings? A device > can't have multiple names, can it? @@ -71,7 +75,7 @@ one string in a given list, so the trailing "*" is needed. > various device types handled by file2alias.c, it seems that most of > them don't need the trailing "*", and many of them have the problem I > was mentioning. -> +>=20 > Can't we just stop handle_moddevtable() from adding a tailing "*" > automatically, and just let the device types which need it, add it on > their own? @@ -89,8 +93,3 @@ file2alias::do_table() and suppress the trailing "*" for i2c? Thanks, Kay - -_______________________________________________ -Linuxppc-dev mailing list -Linuxppc-dev@ozlabs.org -https://ozlabs.org/mailman/listinfo/linuxppc-dev diff --git a/a/content_digest b/N1/content_digest index 13726b9..eca4651 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -15,11 +15,13 @@ "On Mon, 2008-04-28 at 17:40 +0200, Jean Delvare wrote:\n" "> On Mon, 28 Apr 2008 17:07:25 +0200, Kay Sievers wrote:\n" "> > On Mon, 2008-04-28 at 11:39 +0200, Jean Delvare wrote:\n" - "> > > One thing I am still not happy with is that the aliases created have a\n" + "> > > One thing I am still not happy with is that the aliases created have =\n" + "a\n" "> > > trailing \"*\":\n" - "> > > \n" + "> > >=20\n" "> > > $ /sbin/modinfo lm90\n" - "> > > filename: /lib/modules/2.6.25-git11/kernel/drivers/hwmon/lm90.ko\n" + "> > > filename: /lib/modules/2.6.25-git11/kernel/drivers/hwmon/lm90.k=\n" + "o\n" "> > > author: Jean Delvare <khali@linux-fr.org>\n" "> > > description: LM90/ADM1032 driver\n" "> > > license: GPL\n" @@ -33,32 +35,34 @@ "> > > alias: i2c:adt7461*\n" "> > > alias: i2c:max6680*\n" "> > > $\n" - "> > > \n" - "> > > This would cause trouble if one I2C chip name matches the beginning of\n" + "> > >=20\n" + "> > > This would cause trouble if one I2C chip name matches the beginning o=\n" + "f\n" "> > > another I2C chip name and both chips are supported by different\n" "> > > drivers. This has yet to be seen, but still, I'd like to see this\n" "> > > problem fixed quickly.\n" - "> > \n" - "> > \357\273\277Right, the trailing \"*\" is not nice.\n" - "> > \n" + "> >=20\n" + "> > =EF=BB=BFRight, the trailing \"*\" is not nice.\n" + "> >=20\n" "> > We should terminate the string, so the trailing \"*\" will not match\n" "> > longer strings. The usual thing is to add a \":\" to the end, which would\n" "> > then show up as\n" "> > alias: i2c:max6680:*\n" - "> > \n" + "> >=20\n" "> > See DMI and ACPI:\n" "> > alias dmi:*:svnFUJITSU:pnLifeBook*:pvr*:rvnFUJITSU:* apanel\n" "> > alias acpi*:ASIM0000:* atlas_btns\n" - "> \n" + ">=20\n" "> I didn't know about these cases, thanks for the hint.\n" - "> \n" - "> > \n" + ">=20\n" + "> >=20\n" "> > If i2c device modaliases could ever contain multiple strings, it should\n" "> > be:\n" "> > alias: i2c*:max6680:*\n" - "> > \357\273\277to match the module, regardless of the order of the strings in the\n" + "> > =EF=BB=BFto match the module, regardless of the order of the strings in=\n" + " the\n" "> > modalias:\n" - "> \n" + ">=20\n" "> Why would i2c device modaliases ever contain multiple strings? A device\n" "> can't have multiple names, can it?\n" "\n" @@ -85,7 +89,7 @@ "> various device types handled by file2alias.c, it seems that most of\n" "> them don't need the trailing \"*\", and many of them have the problem I\n" "> was mentioning.\n" - "> \n" + ">=20\n" "> Can't we just stop handle_moddevtable() from adding a tailing \"*\"\n" "> automatically, and just let the device types which need it, add it on\n" "> their own?\n" @@ -102,11 +106,6 @@ "file2alias::do_table() and suppress the trailing \"*\" for i2c?\n" "\n" "Thanks,\n" - "Kay\n" - "\n" - "_______________________________________________\n" - "Linuxppc-dev mailing list\n" - "Linuxppc-dev@ozlabs.org\n" - https://ozlabs.org/mailman/listinfo/linuxppc-dev + Kay -22796f3c848d53678d71fd7308d80ef81c5d0055e6e5f2281acdfe7ab3281cc8 +c30d1035287aa2f05eb4778ad7f7617d7a7d29abd4fc4e4989a250b31d521cd6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.