From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92693C2D0CD for ; Mon, 19 May 2025 06:27:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4566160E9C; Mon, 19 May 2025 06:27:45 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id S2U8Oy4_rks9; Mon, 19 May 2025 06:27:44 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B1BC360EBF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1747636064; bh=RZRSFEz+bNefA1vWC1Hlpfk3z/yQrqpzvcfmw63ePAA=; h=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HXcPLS+ICDz3PXAdLzVrEVer4q0qkVtY9ECAUjD0pOPZjY53aTCcsX3N83I5fkhzj D67lgnEHnBJhOiTVuBMOl4+jYzwStM9c916SOeyatG5ZuWTpnvO4Dv7MpqlNASeLNZ f5ZJ560ycys/R0/9+74UWl/hiQJG1dPmEfKlwKxUYN3dbzgsjJybeSlGuco69NmskE 7VJndB/5dM+wLrC8xFehwfzeWGCyFdbMaSnEFlArCNtZ3KYe4if5Hd9VEe9NVZxb1t hWGkS8LHhqf1immMQgfCCdVwF7sHsge+38cqtHy4tleX1nZGh5SVrQUD3Rt7EU+27j 9Z1wljQ+Ci2Qg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id B1BC360EBF; Mon, 19 May 2025 06:27:44 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 991A21BA for ; Mon, 19 May 2025 06:27:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7F6CC404DD for ; Mon, 19 May 2025 06:27:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id vqSszV5Taogw for ; Mon, 19 May 2025 06:27:43 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=198.175.65.17; helo=mgamail.intel.com; envelope-from=faizal.abdul.rahim@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 99EB940422 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 99EB940422 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by smtp2.osuosl.org (Postfix) with ESMTPS id 99EB940422 for ; Mon, 19 May 2025 06:27:42 +0000 (UTC) X-CSE-ConnectionGUID: ZjX9bhvXRNaOVshYcWyxkQ== X-CSE-MsgGUID: KT45KTOJTACwQmk+vJPNPA== X-IronPort-AV: E=McAfee;i="6700,10204,11437"; a="49503809" X-IronPort-AV: E=Sophos;i="6.15,300,1739865600"; d="scan'208";a="49503809" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2025 23:27:42 -0700 X-CSE-ConnectionGUID: UK5odDNjSF+5FI6KHpYkxA== X-CSE-MsgGUID: KP5sPoGBQVKkqbLHSlAehg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,300,1739865600"; d="scan'208";a="170313674" Received: from mohdfai2-mobl.gar.corp.intel.com (HELO [10.247.73.217]) ([10.247.73.217]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2025 23:27:38 -0700 Message-ID: <12093d3c-ca0a-46fd-950e-6af1448ee079@linux.intel.com> Date: Mon, 19 May 2025 14:27:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Simon Horman Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Aleksandr Loktionov , Chwee-Lin Choong References: <20250514042945.2685273-1-faizal.abdul.rahim@linux.intel.com> <20250514042945.2685273-9-faizal.abdul.rahim@linux.intel.com> <20250516094336.GH1898636@horms.kernel.org> Content-Language: en-US From: "Abdul Rahim, Faizal" In-Reply-To: <20250516094336.GH1898636@horms.kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747636063; x=1779172063; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=05be7fLfzW+Lkh9/B6CDCkEvJrnVcJV+48VP51XW+4I=; b=Xm9eHj4kmdmtQX3HVBJdX6tFTSHdw61MZAZPPL/iixunRuJWcr1lDqox U9hTWCqiW/RMA0+5ZdTkjij2If98fQ5XgJczdrQW0z2QvSEPdYdqX/H1I KRU/XuK083hFT11rQ1HDWQCzpracErCABuYPoWtqj4QSM3/njtD6CFXU0 UyBoPrHR6WgoZoIUcouatcd7wWpi69V03PpDih2AAAQlZ9FpJ6Z32WWS8 V0pBh3JVUGjmxEy5GuDxgg/DbP/ht4f0qmjX9zhw3nG6fJYY0puNoX8f+ UVpSKPDNBuhGsC1PP94jdQ09qQLU4f4z4XAjS2q1P1yZAUPYzEBcI65Xu g==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Xm9eHj4k Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 8/8] igc: SW pad preemptible frames for correct mCRC calculation X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 16/5/2025 5:43 pm, Simon Horman wrote: > On Wed, May 14, 2025 at 12:29:45AM -0400, Faizal Rahim wrote: >> From: Chwee-Lin Choong >> >> A hardware-padded frame transmitted from the preemptible queue >> results in an incorrect mCRC computation by hardware, as the >> padding bytes are not included in the mCRC calculation. >> >> To address this, manually pad frames in preemptible queues to a >> minimum length of 60 bytes using skb_padto() before transmission. >> This ensures that the hardware includes the padding bytes in the >> mCRC computation, producing a correct mCRC value. >> >> Signed-off-by: Chwee-Lin Choong >> Signed-off-by: Faizal Rahim > > Hi Faizal, all, > > Perhaps it would be best to shuffle this patch within this series > so that it appears before the patches that add pre-emption support. > That way, when the are added the bug isn't present. > Makes sense, will update. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A02524468E; Mon, 19 May 2025 06:27:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747636065; cv=none; b=SODsbg3MWr6CoP0xG7FIOan7rt8a+p2D1vviFwXIny61ZhQlzxm3urwimnjtxXF5pZHVaJxLaDDexOk+72VVWpEwTDzl3hFfVCOSegzbzLq+M6h5OI+v+8YQfxuNTDxpIDcFtdOdV23ODTD6CjVkU6kY/h2Z57fY8HupR7rPY2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747636065; c=relaxed/simple; bh=05be7fLfzW+Lkh9/B6CDCkEvJrnVcJV+48VP51XW+4I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HQOJncN4Le6bj5892TZPut7AR2WVyhMXLbnfLVoRv2HqXGaccO23pH74/qPw9btzEL/wifvI4FKpcXrQ66e+nBpuQ9H+eufQiPlMFeftPiPo+JJxQqtANdB4gJYfoep5Qeou1C3bg7OdrpXW7nsQOtXqiYxWOoLHDelR9klWj34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dDGSci3L; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dDGSci3L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747636064; x=1779172064; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=05be7fLfzW+Lkh9/B6CDCkEvJrnVcJV+48VP51XW+4I=; b=dDGSci3L0NxJ6+0HS5/VT4r0p3H0vHaH6SGvrp6ZHtgzzgqKcivfo4Yc rDkZmL4T9EsM0Yp5/5SWbkjiOZ4HqqsZkv+RftgT6VKdkZKLADRpPg17l hra4dMx9fM35Bkr14/m5VhczfjgnLnYlB5vYCyO4MfG754dHG69FnSNUI MxPE3JcA+ScjOIR7xgBPa682cuRWI5/aNLsgpPHVrYC1d+jRkb+/WI+yy URLQP/64uJXt5i7viZNjUTy9NklF1D7a2oljkm+Nb0BDF0TxCxuIvR/WW 0HqdFTPSWzNnoRwUWXkU0lHFXpBj5whuTietw7lry1EIn2pvmmaBTE4rC A==; X-CSE-ConnectionGUID: 3W948e2hQwSCWUOv9wUs0g== X-CSE-MsgGUID: ZoSeOeUKRnSwZVf+RXL+Ng== X-IronPort-AV: E=McAfee;i="6700,10204,11437"; a="49503810" X-IronPort-AV: E=Sophos;i="6.15,300,1739865600"; d="scan'208";a="49503810" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2025 23:27:42 -0700 X-CSE-ConnectionGUID: UK5odDNjSF+5FI6KHpYkxA== X-CSE-MsgGUID: KP5sPoGBQVKkqbLHSlAehg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,300,1739865600"; d="scan'208";a="170313674" Received: from mohdfai2-mobl.gar.corp.intel.com (HELO [10.247.73.217]) ([10.247.73.217]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2025 23:27:38 -0700 Message-ID: <12093d3c-ca0a-46fd-950e-6af1448ee079@linux.intel.com> Date: Mon, 19 May 2025 14:27:36 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH iwl-next v2 8/8] igc: SW pad preemptible frames for correct mCRC calculation To: Simon Horman Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Aleksandr Loktionov , Chwee-Lin Choong References: <20250514042945.2685273-1-faizal.abdul.rahim@linux.intel.com> <20250514042945.2685273-9-faizal.abdul.rahim@linux.intel.com> <20250516094336.GH1898636@horms.kernel.org> Content-Language: en-US From: "Abdul Rahim, Faizal" In-Reply-To: <20250516094336.GH1898636@horms.kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/5/2025 5:43 pm, Simon Horman wrote: > On Wed, May 14, 2025 at 12:29:45AM -0400, Faizal Rahim wrote: >> From: Chwee-Lin Choong >> >> A hardware-padded frame transmitted from the preemptible queue >> results in an incorrect mCRC computation by hardware, as the >> padding bytes are not included in the mCRC calculation. >> >> To address this, manually pad frames in preemptible queues to a >> minimum length of 60 bytes using skb_padto() before transmission. >> This ensures that the hardware includes the padding bytes in the >> mCRC computation, producing a correct mCRC value. >> >> Signed-off-by: Chwee-Lin Choong >> Signed-off-by: Faizal Rahim > > Hi Faizal, all, > > Perhaps it would be best to shuffle this patch within this series > so that it appears before the patches that add pre-emption support. > That way, when the are added the bug isn't present. > Makes sense, will update. Thanks!