All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] lib: add ascii hex helper functions
Date: Thu, 01 May 2008 14:58:58 -0700	[thread overview]
Message-ID: <1209679138.24729.181.camel@brick> (raw)
In-Reply-To: <1209678260.4841.16.camel@localhost>

On Thu, 2008-05-01 at 14:44 -0700, Joe Perches wrote:
> On Thu, 2008-05-01 at 14:35 -0700, Harvey Harrison wrote:
> > The whole point is to start to centralize everybody's private copy of
> > a hex_asc equivalent.
> 
> Which should be done via some function,
> not via a char array right?
> 

It's just getting a char from the array, a static inline maybe rather
than the hex_asc_hi/lo macros, but the array would still need to be
extern so the inlines could get at it.  The whole point is avoiding a
function call...which is why everybody has their own static array they
can use directly in the first place.

Harvey


      reply	other threads:[~2008-05-01 21:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 20:51 [PATCH 1/4] lib: add ascii hex helper functions Harvey Harrison
2008-05-01 21:15 ` Andrew Morton
2008-05-01 21:32   ` Harvey Harrison
2008-05-01 21:28 ` Joe Perches
2008-05-01 21:35   ` Harvey Harrison
2008-05-01 21:44     ` Joe Perches
2008-05-01 21:58       ` Harvey Harrison [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209679138.24729.181.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.