From: "Santi Béjar" <sbejar@gmail.com>
To: git@vger.kernel.org
Cc: "Santi Béjar" <sbejar@gmail.com>
Subject: [PATCH 0/2] Show committer ident in some cases
Date: Fri, 2 May 2008 20:22:19 +0200 [thread overview]
Message-ID: <1209752541-19111-1-git-send-email-sbejar@gmail.com> (raw)
Hi *,
This patch series tries to make more evident the committer ident
used in a commit to prevent using the wrong one.
The definition of "wrong committer" could be:
1) user.{name,email} or GIT_COMMITTER_{NAME,EMAIL} is not a wrong committer.
2) automatic without a domain name (user@hostname.(none)) is a wrong committer.
(not handled with this patch series)
3) automatic or partially set ident:
a) wrong committer for some users
b) right committer for others
The different strategies are.. Show the committer:
1) always
2) when user.warn = yes (defaulting to yes)
3) when it is automatic
a) always
b) and different from parent
c) and different from a list of valid committer idents
d) and when user.WarnAutomatic = yes (defaulting to yes)
The first patch implements 3a
The second patch implements 3d
I prefer 3a.
Santi
Santi Béjar (2):
commit: Show committer if automatic
user.warnautomatic: add config to control if the committer ident is
shown
Documentation/config.txt | 4 ++++
builtin-commit.c | 40 +++++++++++++++++++++++++++++++++++++---
cache.h | 2 ++
config.c | 9 +++++++++
environment.c | 2 ++
ident.c | 3 +++
t/t7502-commit.sh | 31 +++++++++++++++++++++++++++++--
7 files changed, 86 insertions(+), 5 deletions(-)
next reply other threads:[~2008-05-02 18:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:22 Santi Béjar [this message]
2008-05-02 18:22 ` [PATCH 1/2] commit: Show committer if automatic Santi Béjar
2008-05-03 18:33 ` Junio C Hamano
2008-05-03 20:28 ` Santi Béjar
2008-05-02 18:22 ` [PATCH 2/2] user.warnautomatic: add config to control if the committer ident is shown Santi Béjar
2008-05-02 21:44 ` [PATCH 0/2] Show committer ident in some cases Junio C Hamano
2008-05-02 22:07 ` Santi Béjar
2008-05-02 22:32 ` Junio C Hamano
2008-05-03 10:18 ` Santi Béjar
2008-05-05 3:30 ` Jeff King
2008-05-05 5:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209752541-19111-1-git-send-email-sbejar@gmail.com \
--to=sbejar@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.