From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JsQi7-00071E-Md for mharc-grub-devel@gnu.org; Sat, 03 May 2008 19:00:07 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JsQi6-00070u-7b for grub-devel@gnu.org; Sat, 03 May 2008 19:00:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JsQi4-00070c-R1 for grub-devel@gnu.org; Sat, 03 May 2008 19:00:05 -0400 Received: from [199.232.76.173] (port=39671 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JsQi4-00070Z-IQ for grub-devel@gnu.org; Sat, 03 May 2008 19:00:04 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JsQi4-0003V8-67 for grub-devel@gnu.org; Sat, 03 May 2008 19:00:04 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 03 May 2008 19:00:03 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 9CBDF619058 for ; Sat, 3 May 2008 19:00:02 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Sat, 03 May 2008 18:59:54 -0400 Message-Id: <1209855594.24895.5.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: ata.c and sata disks X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2008 23:00:06 -0000 On Sat, 2008-05-03 at 19:35 +0200, Marco Vega Trucillo wrote: > Hi to all, > > I tried to modify ata.c simply add more ioaddress (I attach the diff file > from 1.96 version), and it work and recognize > my four sata disk on different pc. I think it's generally considered unsafe to probe addresses above 0x3ff without making sure they belong to a compatible device. The device should be found on the PCI bus, and enabled if necessary. > -/* try address of commons sata controller */ > -static const int grub_ata_ioaddress[] = {0x1f0, 0x170 > ,0x9800,0x9000,0x8800,0x18f8,0x18f0}; Your patch is reversed. Also, it would be better to make a patch against the current CVS version. > - for (port = 0; port <= 6; port++) > + for (port = 0; port <= 1; port++) Using sizeof would be great here. Unless we switch to using a dynamic list of interface. -- Regards, Pavel Roskin