From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: David Miller <davem@davemloft.net>,
a.p.zijlstra@chello.nl, efault@gmx.de, elendil@planet.nl,
parag.warudkar@gmail.com, linux-kernel@vger.kernel.org,
guichaz@yahoo.fr, andi@firstfloor.org
Subject: Re: 'global' rq->clock
Date: Sun, 04 May 2008 12:22:47 +1000 [thread overview]
Message-ID: <1209867767.26383.35.camel@pasglop> (raw)
In-Reply-To: <20080503223844.GA18344@elte.hu>
> on nohz we still keep jiffies uptodate - despite there not being an
> explicit 'keep jiffies uptodate' tick interrupt anymore. So on every
> irq_enter() we roll jiffies forward - if needed - and thus emulate
> jiffies behavior to drivers and core kernel code, etc.
>
> if an IPI on Power does not do an irq_enter() then you might miss out on
> updated jiffies. That might not matter for most jiffies, but you might
> also miss out on the 'touch the softlockup watchdog because we just woke
> from idle' action. This is what triggered the false positive warnings on
> Sparc64.
>
> the same bug existed on x86 too: that too does a few IPIs without
> irq_enter/irq_exit. We now removed the softlockup dependency so it
> should not be required to do an irq_enter()/exit anymore - unless the
> code that the IPI uses accesses jiffies. (but that would be unusual)
Allright, so it looks like we don't have a problem today, though I'll be
careful if some of our CPUs come up with more fancy ways to do IPIs.
Currently they are just normal interrupts, so we do irq_enter/exit and
we process softirqs on the way out.
Ben.
next prev parent reply other threads:[~2008-05-04 2:23 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 0:14 Horrendous Audio Stutter - current git Parag Warudkar
2008-05-02 8:34 ` Peter Zijlstra
2008-05-02 10:32 ` Frans Pop
2008-05-02 10:35 ` Peter Zijlstra
2008-05-02 11:08 ` Peter Zijlstra
2008-05-02 11:37 ` Frans Pop
2008-05-02 11:39 ` Peter Zijlstra
2008-05-02 11:45 ` Frans Pop
2008-05-02 11:51 ` Peter Zijlstra
2008-05-02 12:06 ` Frans Pop
2008-05-02 12:22 ` Parag Warudkar
2008-05-02 13:21 ` Dhaval Giani
2008-05-02 11:10 ` Parag Warudkar
2008-05-02 12:09 ` Mike Galbraith
2008-05-02 12:21 ` Parag Warudkar
2008-05-02 12:37 ` Mike Galbraith
2008-05-02 15:02 ` Mike Galbraith
2008-05-02 15:49 ` Frans Pop
2008-05-02 18:53 ` Frans Pop
2008-05-02 19:27 ` Mike Galbraith
2008-05-02 19:56 ` 'global' rq->clock (was Re: Horrendous Audio Stutter - current git) Peter Zijlstra
2008-05-02 20:38 ` Guillaume Chazarain
2008-05-02 20:46 ` Peter Zijlstra
2008-05-02 22:00 ` 'global' rq->clock David Miller
2008-05-02 21:48 ` David Miller
2008-05-02 10:09 ` Arjan van de Ven
2008-05-04 12:12 ` Peter Zijlstra
2008-05-02 22:07 ` Peter Zijlstra
2008-05-03 8:28 ` Ingo Molnar
2008-05-03 9:05 ` David Miller
2008-05-03 10:10 ` Ingo Molnar
2008-05-03 19:27 ` David Miller
2008-05-03 19:37 ` Ingo Molnar
2008-05-03 22:30 ` Benjamin Herrenschmidt
2008-05-03 22:38 ` Ingo Molnar
2008-05-03 23:04 ` David Miller
2008-05-03 23:36 ` David Miller
2008-05-03 23:38 ` Ingo Molnar
2008-05-03 23:40 ` David Miller
2008-05-03 23:47 ` Ingo Molnar
2008-05-04 2:22 ` Benjamin Herrenschmidt [this message]
2008-05-03 19:28 ` David Miller
2008-05-03 19:39 ` Ingo Molnar
2008-05-03 6:20 ` 'global' rq->clock (was Re: Horrendous Audio Stutter - current git) Mike Galbraith
2008-05-02 19:38 ` Horrendous Audio Stutter - current git Mike Galbraith
2008-05-03 7:13 ` Frans Pop
2008-05-03 7:39 ` Mike Galbraith
2008-05-07 8:26 ` Frans Pop
2008-05-07 8:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209867767.26383.35.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=efault@gmx.de \
--cc=elendil@planet.nl \
--cc=guichaz@yahoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=parag.warudkar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.