From: Joe Perches <joe@perches.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: akpm@linux-foundation.org, paulmck@us.ibm.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] __ratelimit rewrite
Date: Sun, 04 May 2008 19:52:54 -0700 [thread overview]
Message-ID: <1209955974.13011.10.camel@localhost> (raw)
In-Reply-To: <a8e1da0805041958k30c03e20r6dd88f4135d6e5fe@mail.gmail.com>
On Mon, 2008-05-05 at 10:58 +0800, Dave Young wrote:
> On Mon, May 5, 2008 at 10:25 AM, Joe Perches <joe@perches.com> wrote:
> > On Mon, 2008-05-05 at 09:37 +0800, Dave Young wrote:
> > > > I think your changes should then be done in
> > > > printk.h not creating a new ratelimit.h.
> > > IMO ratelimit is not just for printk use now, so a standalone head
> > > file is necessary.
> > What other uses would ratelimit have?
> ratelimit is a general function, another user of it is
> WARN_ON_RATELIMIT in this patch. It could have other usage in future.
You put WARN_ON_RATELIMIT in bug.h right?
WARN_ON in bug.h is a printk
printk.h should #include <asm/bug.h>
kernel.h should not include that file.
What non print related function could be served by ratelimit?
next prev parent reply other threads:[~2008-05-05 3:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 7:07 [PATCH -mm] __ratelimit rewrite Dave Young
2008-05-04 7:54 ` David Miller
2008-05-04 8:13 ` Dave Young
2008-05-04 14:47 ` Joe Perches
2008-05-05 1:37 ` Dave Young
2008-05-05 2:25 ` Joe Perches
2008-05-05 2:58 ` Dave Young
2008-05-05 2:52 ` Joe Perches [this message]
2008-05-05 5:18 ` Dave Young
2008-05-05 5:20 ` David Miller
2008-05-05 2:27 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209955974.13011.10.camel@localhost \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.