From: Daniel Walker <dwalker@mvista.com>
To: "Carlos R. Mafra" <crmafra2@gmail.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
venkatesh.pallipadi@intel.com
Subject: Re: x86: Clean up computation of HPET .mult variables
Date: Mon, 05 May 2008 20:23:38 -0700 [thread overview]
Message-ID: <1210044218.17132.109.camel@localhost.localdomain> (raw)
In-Reply-To: <20080506021321.GA4928@Pilar.virtua.com.br>
On Mon, 2008-05-05 at 23:13 -0300, Carlos R. Mafra wrote:
> So the savings in my patch is due to using the period directly, and
> not the frequency. That's what my idea was, so if you object then
> my attempt was a failure and should be forgotten :-)
>
> Or maybe I should create a clocksource_period2mult to replace
> clocksource_hz2mult and save the extra operation in more places too?
The one concern I have is the rounding that is done in the
clocksource_hz2mult(). The div_sc doesn't include it .. You could add a
clocksource_period2mult(), that would help out any one later that has a
period instead of hz ..
Daniel
next prev parent reply other threads:[~2008-05-06 3:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 23:11 x86: Clean up computation of HPET .mult variables Carlos R. Mafra
2008-05-05 23:58 ` Daniel Walker
2008-05-06 2:13 ` Carlos R. Mafra
2008-05-06 3:23 ` Daniel Walker [this message]
2008-05-06 12:59 ` Carlos R. Mafra
2008-05-06 16:21 ` Daniel Walker
2008-05-06 20:50 ` Carlos R. Mafra
2008-05-07 2:17 ` Daniel Walker
2008-05-07 3:39 ` Carlos R. Mafra
2008-05-07 4:21 ` Daniel Walker
2008-05-07 7:13 ` Ingo Molnar
2008-05-06 12:43 ` Ingo Molnar
2008-05-06 13:13 ` Carlos R. Mafra
2008-05-06 18:51 ` rtc-cmos.c: Build fix Carlos R. Mafra
2008-05-07 7:10 ` Ingo Molnar
2008-05-07 21:31 ` Andrew Morton
2008-05-09 8:32 ` Ingo Molnar
2008-05-09 12:33 ` Carlos R. Mafra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210044218.17132.109.camel@localhost.localdomain \
--to=dwalker@mvista.com \
--cc=crmafra2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.