From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JtUmv-000521-OW for mharc-grub-devel@gnu.org; Tue, 06 May 2008 17:33:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtUmu-00051t-9x for grub-devel@gnu.org; Tue, 06 May 2008 17:33:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtUms-0004zn-Ma for grub-devel@gnu.org; Tue, 06 May 2008 17:33:27 -0400 Received: from [199.232.76.173] (port=59429 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtUms-0004zi-JK for grub-devel@gnu.org; Tue, 06 May 2008 17:33:26 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JtUms-0000Nu-4X for grub-devel@gnu.org; Tue, 06 May 2008 17:33:26 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 06 May 2008 17:33:24 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 6781F619058 for ; Tue, 6 May 2008 17:33:24 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1210087760.30746.44.camel@zakaz.uk.xensource.com> References: <1209065321.2063.8.camel@localhost.localdomain> <1210087760.30746.44.camel@zakaz.uk.xensource.com> Content-Type: text/plain Date: Tue, 06 May 2008 17:33:23 -0400 Message-Id: <1210109603.20736.14.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Please support installation on Xen virtual block devices X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 May 2008 21:33:28 -0000 On Tue, 2008-05-06 at 16:29 +0100, Ian Campbell wrote: > Any comments on this patch? It's basically OK, bug please provide the GNU style ChangeLog entry. The second part of the patch doesn't need preprocessor conditionals because it's already compiled for Linux only. Please use tabs for indentation rather than 8 spaces. The innermost block is indented two spaces too far. In the long term, I would prefer that we don't need device.map at all. This is discussed in a separate thread. -- Regards, Pavel Roskin