From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JtnW4-0006h6-Qw for mharc-grub-devel@gnu.org; Wed, 07 May 2008 13:33:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtnW3-0006gp-Qp for grub-devel@gnu.org; Wed, 07 May 2008 13:33:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtnW2-0006fC-78 for grub-devel@gnu.org; Wed, 07 May 2008 13:33:18 -0400 Received: from [199.232.76.173] (port=40409 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtnW2-0006ey-3b for grub-devel@gnu.org; Wed, 07 May 2008 13:33:18 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JtnW1-0007WD-Fj for grub-devel@gnu.org; Wed, 07 May 2008 13:33:17 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 07 May 2008 13:33:16 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id BEB45619058 for ; Wed, 7 May 2008 13:33:15 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080507124326.GA16492@thorin> References: <1209065321.2063.8.camel@localhost.localdomain> <1210087760.30746.44.camel@zakaz.uk.xensource.com> <1210109603.20736.14.camel@dv> <20080507124326.GA16492@thorin> Content-Type: text/plain Date: Wed, 07 May 2008 13:33:15 -0400 Message-Id: <1210181595.2321.22.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Please support installation on Xen virtual block devices X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2008 17:33:20 -0000 On Wed, 2008-05-07 at 14:43 +0200, Robert Millan wrote: > On Tue, May 06, 2008 at 05:33:23PM -0400, Pavel Roskin wrote: > > On Tue, 2008-05-06 at 16:29 +0100, Ian Campbell wrote: > > > Any comments on this patch? > > > > It's basically OK, bug please provide the GNU style ChangeLog entry. > > The second part of the patch doesn't need preprocessor conditionals > > because it's already compiled for Linux only. Please use tabs for > > indentation rather than 8 spaces. The innermost block is indented two > > spaces too far. > > Ian, it looks like you copied this style from existing code. Is that so? > > In that case, I don't think the indentation issue concerns your patch (if we > have to fix indentation, we could just do it in the whole file). Apparently, it was copied from the code that was inside an extra "for" loop. Anyway, it's a very minor issue, and I would just apply the patch right now, but I prefer not to write changelog entries for others. -- Regards, Pavel Roskin