From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jtok6-0001DT-Rw for mharc-grub-devel@gnu.org; Wed, 07 May 2008 14:51:54 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jtok4-0001DO-Ib for grub-devel@gnu.org; Wed, 07 May 2008 14:51:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jtok3-0001DC-52 for grub-devel@gnu.org; Wed, 07 May 2008 14:51:52 -0400 Received: from [199.232.76.173] (port=39094 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jtok2-0001D9-UQ for grub-devel@gnu.org; Wed, 07 May 2008 14:51:50 -0400 Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jtok2-00080e-PM for grub-devel@gnu.org; Wed, 07 May 2008 14:51:51 -0400 Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout02-winn.ispmail.ntl.com with ESMTP id <20080507185529.INLY58.mtaout02-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com> for ; Wed, 7 May 2008 19:55:29 +0100 Received: from hopkins.hellion.org.uk ([81.102.157.50]) by aamtaout03-winn.ispmail.ntl.com with ESMTP id <20080507185930.JOH26699.aamtaout03-winn.ispmail.ntl.com@hopkins.hellion.org.uk> for ; Wed, 7 May 2008 19:59:30 +0100 Received: from azathoth.hellion.org.uk ([192.168.1.5]) by hopkins.hellion.org.uk with esmtp (Exim 4.63) (envelope-from ) id 1Jtojs-0006cn-LU for grub-devel@gnu.org; Wed, 07 May 2008 19:51:46 +0100 From: Ian Campbell To: The development of GRUB 2 In-Reply-To: <1210181595.2321.22.camel@dv> References: <1209065321.2063.8.camel@localhost.localdomain> <1210087760.30746.44.camel@zakaz.uk.xensource.com> <1210109603.20736.14.camel@dv> <20080507124326.GA16492@thorin> <1210181595.2321.22.camel@dv> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-i27y/hn6h1I0elyEELE8" Date: Wed, 07 May 2008 19:51:40 +0100 Message-Id: <1210186300.18090.16.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 X-SA-Exim-Connect-IP: 192.168.1.5 X-SA-Exim-Mail-From: ijc@hellion.org.uk X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on hopkins.hellion.org.uk) X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) Subject: Re: Please support installation on Xen virtual block devices X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2008 18:51:53 -0000 --=-i27y/hn6h1I0elyEELE8 Content-Type: multipart/mixed; boundary="=-1GePmSpvbMHoY58N94YH" --=-1GePmSpvbMHoY58N94YH Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2008-05-07 at 13:33 -0400, Pavel Roskin wrote: > Apparently, it was copied from the code that was inside an extra "for" > loop. Anyway, it's a very minor issue, and I would just apply the patch > right now, but I prefer not to write changelog entries for others. Sorry about that. An updated version is attached with changelog and (hopefully) correct indentation. I wasn't sure about the pre-processor conditionals, there seems to be lots of existing ifdef __linux__ in there and the device path is pretty Linux specific. I merged it into the one above but if you want them gone I will redo. Ian. --=20 Ian Campbell omnibiblious, adj.: Indifferent to type of drink. Ex: "Oh, you can get me anything. I'm omnibiblious." --=-1GePmSpvbMHoY58N94YH Content-Disposition: attachment; filename=support-xvd-v2.diff Content-Type: text/x-patch; name=support-xvd-v2.diff; charset=ISO-8859-1 Content-Transfer-Encoding: base64 ZGlmZiAtcHVyTiAtWCAvaG9tZS9pamMvZGV2ZWxvcG1lbnQvZG9udGRpZmYudHh0IGdydWIyLTEu OTYrMjAwODA0MzAub3JpZy9DaGFuZ2VMb2cgZ3J1YjItMS45NisyMDA4MDQzMC9DaGFuZ2VMb2cN Ci0tLSBncnViMi0xLjk2KzIwMDgwNDMwLm9yaWcvQ2hhbmdlTG9nCTIwMDgtMDQtMzAgMTI6MDY6 MjYuMDAwMDAwMDAwICswMTAwDQorKysgZ3J1YjItMS45NisyMDA4MDQzMC9DaGFuZ2VMb2cJMjAw OC0wNS0wNyAxOTo0MToxMC4wMDAwMDAwMDAgKzAxMDANCkBAIC0xLDMgKzEsOSBAQA0KKzIwMDgt MDUtMDcgIElhbiBDYW1wYmVsbCAgPGlqY0BoZWxsaW9uLm9yZy51az4NCisNCisJKiB1dGlsL2Jp b3NkaXNrLmMgKGdldF9vc19kaXNrKTogUmVjb2duaXNlIHh2ZCB0eXBlIGRpc2tzLg0KKwkqIHV0 aWwvZ3J1Yi1ta2RldmljZW1hcC5jIChnZXRfeHZkX2Rpc2tfbmFtZSk6IE5ldyBmdW5jdGlvbi4N CisJKG1ha2VfZGV2aWNlX21hcCk6IE91dHB1dCBlbnRyaWVzIGZvciB4dmQgdHlwZSBkaXNrcy4N CisJDQogMjAwOC0wNC0zMCAgUm9iZXJ0IE1pbGxhbiAgPHJtaEBheWJhYnR1LmNvbT4NCiANCiAJ QmFzZWQgb24gcGF0Y2ggZnJvbSBGYWJpYW4gR3JlZmZyYXRoIDxncmVmZnJhdGhAbGVhdC5ydWIu ZGU+DQpkaWZmIC1wdXJOIC1YIC9ob21lL2lqYy9kZXZlbG9wbWVudC9kb250ZGlmZi50eHQgZ3J1 YjItMS45NisyMDA4MDQzMC5vcmlnL3V0aWwvYmlvc2Rpc2suYyBncnViMi0xLjk2KzIwMDgwNDMw L3V0aWwvYmlvc2Rpc2suYw0KLS0tIGdydWIyLTEuOTYrMjAwODA0MzAub3JpZy91dGlsL2Jpb3Nk aXNrLmMJMjAwOC0wNC0wNyAxNjowMDoyNy4wMDAwMDAwMDAgKzAxMDANCisrKyBncnViMi0xLjk2 KzIwMDgwNDMwL3V0aWwvYmlvc2Rpc2suYwkyMDA4LTA1LTA3IDE5OjM0OjQyLjAwMDAwMDAwMCAr MDEwMA0KQEAgLTY0NSw2ICs2NDUsMTMgQEAgZ2V0X29zX2Rpc2sgKGNvbnN0IGNoYXIgKm9zX2Rl dikNCiAJICByZXR1cm4gcGF0aDsNCiAJfQ0KICAgICAgIA0KKyAgICAgIGlmICgoc3RybmNtcCAo Inh2ZCIsIHAsIDMpID09IDApICYmIHBbM10gPj0gJ2EnICYmIHBbM10gPD0gJ3onKQ0KKyAgICAg ICAgew0KKwkgIC8qIC9kZXYveHZkW2Etel1bMC05XSogKi8NCisJICBwWzRdID0gJ1wwJzsNCisJ ICByZXR1cm4gcGF0aDsNCisJfQ0KKw0KICAgICAgIC8qIElmIHRoaXMgaXMgYW4gSURFIGRpc2sg b3IgYSBTQ1NJIGRpc2suICAqLw0KICAgICAgIGlmICgoc3RybmNtcCAoImhkIiwgcCwgMikgPT0g MA0KIAkgICB8fCBzdHJuY21wICgic2QiLCBwLCAyKSA9PSAwKQ0KZGlmZiAtcHVyTiAtWCAvaG9t ZS9pamMvZGV2ZWxvcG1lbnQvZG9udGRpZmYudHh0IGdydWIyLTEuOTYrMjAwODA0MzAub3JpZy91 dGlsL2dydWItbWtkZXZpY2VtYXAuYyBncnViMi0xLjk2KzIwMDgwNDMwL3V0aWwvZ3J1Yi1ta2Rl dmljZW1hcC5jDQotLS0gZ3J1YjItMS45NisyMDA4MDQzMC5vcmlnL3V0aWwvZ3J1Yi1ta2Rldmlj ZW1hcC5jCTIwMDgtMDQtMDYgMTg6NTE6NTUuMDAwMDAwMDAwICswMTAwDQorKysgZ3J1YjItMS45 NisyMDA4MDQzMC91dGlsL2dydWItbWtkZXZpY2VtYXAuYwkyMDA4LTA1LTA3IDE5OjQ5OjI2LjAw MDAwMDAwMCArMDEwMA0KQEAgLTI3Myw2ICsyNzMsMTIgQEAgZ2V0X2kyb19kaXNrX25hbWUgKGNo YXIgKm5hbWUsIGNoYXIgdW5pdA0KIHsNCiAgIHNwcmludGYgKG5hbWUsICIvZGV2L2kyby9oZCVj IiwgdW5pdCk7DQogfQ0KKw0KK3N0YXRpYyB2b2lkDQorZ2V0X3h2ZF9kaXNrX25hbWUgKGNoYXIg Km5hbWUsIGludCB1bml0KQ0KK3sNCisgIHNwcmludGYgKG5hbWUsICIvZGV2L3h2ZCVjIiwgdW5p dCArICdhJyk7DQorfQ0KICNlbmRpZg0KIA0KIC8qIENoZWNrIGlmIERFVklDRSBjYW4gYmUgcmVh ZC4gSWYgYW4gZXJyb3Igb2NjdXJzLCByZXR1cm4gemVybywNCkBAIC01MTMsNiArNTE5LDIyIEBA IG1ha2VfZGV2aWNlX21hcCAoY29uc3QgY2hhciAqZGV2aWNlX21hcCwNCiAJICB9DQogICAgICAg fQ0KICAgfQ0KKw0KKyAgLyogWGVuIFZpcnR1YWwgRGlza3MuICovDQorICBmb3IgKGkgPSAwOyBp IDwgMTY7IGkrKykNCisgICAgew0KKyAgICAgIGNoYXIgbmFtZVsxNl07DQorDQorICAgICAgZ2V0 X3h2ZF9kaXNrX25hbWUgKG5hbWUsIGkpOw0KKyAgICAgIGlmIChjaGVja19kZXZpY2UgKG5hbWUp KQ0KKwl7DQorCSAgY2hhciAqcDsNCisJICBwID0gZ3J1Yl91dGlsX2dldF9kaXNrX25hbWUgKG51 bV9oZCwgbmFtZSk7DQorCSAgZnByaW50ZiAoZnAsICIoJXMpXHQlc1xuIiwgcCwgbmFtZSk7DQor CSAgZnJlZSAocCk7DQorCSAgbnVtX2hkKys7DQorCX0NCisgICAgfQ0KICNlbmRpZiAvKiBfX2xp bnV4X18gKi8NCiANCiAgZmluaXNoOg0K --=-1GePmSpvbMHoY58N94YH-- --=-i27y/hn6h1I0elyEELE8 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBIIfo8M0+0qS9rzVkRAvKJAKDXfBgjreiGkEqBMZ6PZpyHZRn7FgCg3ucu NBIdiCyJm46KBWuXsEeXafQ= =hoDK -----END PGP SIGNATURE----- --=-i27y/hn6h1I0elyEELE8--