From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jtqa6-0008Kn-BT for mharc-grub-devel@gnu.org; Wed, 07 May 2008 16:49:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jtqa4-0008Ki-IF for grub-devel@gnu.org; Wed, 07 May 2008 16:49:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jtqa0-0008Jk-W0 for grub-devel@gnu.org; Wed, 07 May 2008 16:49:39 -0400 Received: from [199.232.76.173] (port=60063 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jtqa0-0008Jh-Ss for grub-devel@gnu.org; Wed, 07 May 2008 16:49:36 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1Jtqa0-0001EM-Ck for grub-devel@gnu.org; Wed, 07 May 2008 16:49:36 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 07 May 2008 16:49:35 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 90832619058 for ; Wed, 7 May 2008 16:49:34 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1210186300.18090.16.camel@localhost.localdomain> References: <1209065321.2063.8.camel@localhost.localdomain> <1210087760.30746.44.camel@zakaz.uk.xensource.com> <1210109603.20736.14.camel@dv> <20080507124326.GA16492@thorin> <1210181595.2321.22.camel@dv> <1210186300.18090.16.camel@localhost.localdomain> Content-Type: text/plain Date: Wed, 07 May 2008 16:49:28 -0400 Message-Id: <1210193368.17396.7.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Please support installation on Xen virtual block devices X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2008 20:49:40 -0000 On Wed, 2008-05-07 at 19:51 +0100, Ian Campbell wrote: > On Wed, 2008-05-07 at 13:33 -0400, Pavel Roskin wrote: > > Apparently, it was copied from the code that was inside an extra "for" > > loop. Anyway, it's a very minor issue, and I would just apply the patch > > right now, but I prefer not to write changelog entries for others. > > Sorry about that. An updated version is attached with changelog and > (hopefully) correct indentation. > > I wasn't sure about the pre-processor conditionals, there seems to be > lots of existing ifdef __linux__ in there and the device path is pretty > Linux specific. I merged it into the one above but if you want them gone > I will redo. Applied. It looks like you missed changes to linux_find_partition(). I'll fix it myself (if indeed necessary). -- Regards, Pavel Roskin