From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jtqru-0005no-39 for mharc-grub-devel@gnu.org; Wed, 07 May 2008 17:08:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jtqrs-0005li-7Y for grub-devel@gnu.org; Wed, 07 May 2008 17:08:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jtqro-0005hd-61 for grub-devel@gnu.org; Wed, 07 May 2008 17:08:03 -0400 Received: from [199.232.76.173] (port=44160 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jtqro-0005hN-0h for grub-devel@gnu.org; Wed, 07 May 2008 17:08:00 -0400 Received: from mtaout03-winn.ispmail.ntl.com ([81.103.221.49]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jtqrm-0004J0-7c for grub-devel@gnu.org; Wed, 07 May 2008 17:07:59 -0400 Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout03-winn.ispmail.ntl.com with ESMTP id <20080507211221.FSWY22559.mtaout03-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com> for ; Wed, 7 May 2008 22:12:21 +0100 Received: from hopkins.hellion.org.uk ([81.102.157.50]) by aamtaout02-winn.ispmail.ntl.com with ESMTP id <20080507211025.IJMF17393.aamtaout02-winn.ispmail.ntl.com@hopkins.hellion.org.uk> for ; Wed, 7 May 2008 22:10:25 +0100 Received: from azathoth.hellion.org.uk ([192.168.1.5]) by hopkins.hellion.org.uk with esmtp (Exim 4.63) (envelope-from ) id 1JtqrW-0006t7-A2 for grub-devel@gnu.org; Wed, 07 May 2008 22:07:48 +0100 From: Ian Campbell To: The development of GRUB 2 In-Reply-To: <1210193368.17396.7.camel@dv> References: <1209065321.2063.8.camel@localhost.localdomain> <1210087760.30746.44.camel@zakaz.uk.xensource.com> <1210109603.20736.14.camel@dv> <20080507124326.GA16492@thorin> <1210181595.2321.22.camel@dv> <1210186300.18090.16.camel@localhost.localdomain> <1210193368.17396.7.camel@dv> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-r197zJtsgVUHn6jshhGC" Date: Wed, 07 May 2008 22:07:41 +0100 Message-Id: <1210194461.18090.61.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 X-SA-Exim-Connect-IP: 192.168.1.5 X-SA-Exim-Mail-From: ijc@hellion.org.uk X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on hopkins.hellion.org.uk) X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) Subject: Re: Please support installation on Xen virtual block devices X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2008 21:08:04 -0000 --=-r197zJtsgVUHn6jshhGC Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2008-05-07 at 16:49 -0400, Pavel Roskin wrote: > On Wed, 2008-05-07 at 19:51 +0100, Ian Campbell wrote: > > On Wed, 2008-05-07 at 13:33 -0400, Pavel Roskin wrote: > > > Apparently, it was copied from the code that was inside an extra "for= " > > > loop. Anyway, it's a very minor issue, and I would just apply the pa= tch > > > right now, but I prefer not to write changelog entries for others. > >=20 > > Sorry about that. An updated version is attached with changelog and > > (hopefully) correct indentation. > >=20 > > I wasn't sure about the pre-processor conditionals, there seems to be > > lots of existing ifdef __linux__ in there and the device path is pretty > > Linux specific. I merged it into the one above but if you want them gon= e > > I will redo. >=20 > Applied. Awesome thanks! > It looks like you missed changes to linux_find_partition(). I'll fix it > myself (if indeed necessary). It doesn't seem to be needed for my simplistic test of installing the grub-pc .deb and running "install-grub /dev/xvda": # dpkg -l grub-pc Desired=3DUnknown/Install/Remove/Purge/Hold | Status=3DNot/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aW= ait/Trig-pend |/ Err?=3D(none)/Hold/Reinst-required/X=3Dboth-problems (Status,Err= : uppercase=3Dbad) ||/ Name Version Description +++-=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D-=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D-=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D ii grub-pc 1.96+20080430- GRand Unified Bootloader, version= 2 (PC/BIOS # grub-install /dev/xvda Installation finished. No error reported. This is the contents of the device map /boot/grub/device.map. Check if this is correct or not. If any of the lines is incorrect, fix it and re-run the script `grub-install'. =20 (hd0) /dev/xvda # grub-install /dev/xvda1 Installation finished. No error reported. This is the contents of the device map /boot/grub/device.map. Check if this is correct or not. If any of the lines is incorrect, fix it and re-run the script `grub-install'. =20 (hd0) /dev/xvda However to my not-so-familiar-with-grub eyes it does look like such a change would make sense. Cheers, Ian. --=20 Ian Campbell I love you more than anything in this world. I don't expect that will last= . -- Elvis Costello --=-r197zJtsgVUHn6jshhGC Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBIIhodM0+0qS9rzVkRAnWvAJ9ov7oeot0yb2vu3Xkkut4cFJrhWACgl/Yi rALFco/ChEza00tyccnXU5w= =lYZb -----END PGP SIGNATURE----- --=-r197zJtsgVUHn6jshhGC--