From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jv4Ds-0000ym-7z for mharc-grub-devel@gnu.org; Sun, 11 May 2008 01:35:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jv4Dq-0000yZ-Tv for grub-devel@gnu.org; Sun, 11 May 2008 01:35:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jv4Dq-0000yN-BB for grub-devel@gnu.org; Sun, 11 May 2008 01:35:46 -0400 Received: from [199.232.76.173] (port=53480 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jv4Dq-0000yK-7V for grub-devel@gnu.org; Sun, 11 May 2008 01:35:46 -0400 Received: from c60.cesmail.net ([216.154.195.49]:20895) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1Jv4Dp-00007J-PT for grub-devel@gnu.org; Sun, 11 May 2008 01:35:46 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 11 May 2008 01:35:44 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id AE68D619058 for ; Sun, 11 May 2008 01:35:43 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1210420988.14928.10.camel@localhost.localdomain> References: <1209065321.2063.8.camel@localhost.localdomain> <1210087760.30746.44.camel@zakaz.uk.xensource.com> <1210109603.20736.14.camel@dv> <20080507124326.GA16492@thorin> <1210181595.2321.22.camel@dv> <1210186300.18090.16.camel@localhost.localdomain> <1210193368.17396.7.camel@dv> <1210194461.18090.61.camel@localhost.localdomain> <20080509125333.GC3705@thorin> <1210420988.14928.10.camel@localhost.localdomain> Content-Type: text/plain Date: Sun, 11 May 2008 01:35:42 -0400 Message-Id: <1210484142.31198.59.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Please support installation on Xen virtual block devices X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 May 2008 05:35:47 -0000 On Sat, 2008-05-10 at 13:03 +0100, Ian Campbell wrote: > On Fri, 2008-05-09 at 14:53 +0200, Robert Millan wrote: > > If you want to test the full functionality, try using grub-probe to convert > > /dev/xvda1 to a grub drive (this checks GRUB knows how to count partitions > > in Xen devices). > > I get these results: > d-i:~# grub-probe -t drive / > (hd0,1) > d-i:~# grub-probe -t drive -d /dev/xvda > (hd0) > d-i:~# grub-probe -t drive -d /dev/xvda1 > (hd0,1) > > Seems correct to me, right? Actually, linux_find_partition() does something different - it converts an offset on the disk to a partition in Linux notation. I understand that linux_find_partition() is only used for cache synchronization. It may fail in more subtle ways. And it looks like support for other devices, such as /dev/i2o, is also missing. Perhaps linux_find_partition() should default to adding the bare number (format="%d") and only specifically handle the cases where something different is needed. -- Regards, Pavel Roskin