From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([66.187.233.31]:37663 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757647AbYEMVrl (ORCPT ); Tue, 13 May 2008 17:47:41 -0400 Subject: Re: [PATCH] wireless, airo: waitbusy() won't delay From: Dan Williams To: Roel Kluin Cc: breed@users.sourceforge.net, linux-wireless@vger.kernel.org, lkml In-Reply-To: <4829F62B.8030003@gmail.com> References: <4829F62B.8030003@gmail.com> Content-Type: text/plain Date: Tue, 13 May 2008 17:43:13 -0400 Message-Id: <1210714993.987.3.camel@localhost.localdomain> (sfid-20080513_234745_415706_0183D1E5) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2008-05-13 at 22:12 +0200, Roel Kluin wrote: > There will be no delay even when COMMAND_BUSY (defined 0x8000) is set: > 0x8000 & (delay < 10000) will evaluate to 0 - when delay is 0. > > Signed-off-by: Roel Kluin Good catch. Acked-by: Dan Williams > --- > diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c > index 45f47c1..efb7444 100644 > --- a/drivers/net/wireless/airo.c > +++ b/drivers/net/wireless/airo.c > @@ -2904,7 +2904,7 @@ EXPORT_SYMBOL(init_airo_card); > > static int waitbusy (struct airo_info *ai) { > int delay = 0; > - while ((IN4500 (ai, COMMAND) & COMMAND_BUSY) & (delay < 10000)) { > + while ((IN4500 (ai, COMMAND) & COMMAND_BUSY) && (delay < 10000)) { > udelay (10); > if ((++delay % 20) == 0) > OUT4500(ai, EVACK, EV_CLEARCOMMANDBUSY); > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html