From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>,
linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH 5/5] b43: move the register write into radio2050_rfover_val
Date: Wed, 14 May 2008 14:53:01 -0700 [thread overview]
Message-ID: <1210801981.6191.44.camel@brick> (raw)
In-Reply-To: <1210795241.29705.26.camel@johannes.berg>
On Wed, 2008-05-14 at 22:00 +0200, Johannes Berg wrote:
> On Wed, 2008-05-14 at 12:35 -0700, Harvey Harrison wrote:
> > On Wed, 2008-05-14 at 21:22 +0200, Michael Buesch wrote:
> > > On Wednesday 14 May 2008 20:56:36 Harvey Harrison wrote:
> > > > It is always called with the same dev, register value as the
> > > > b43_phy_write that wraps around it, make it return void
> > > > and move the register write into radio2050_rfover_val.
> > >
> > > NACK to the whole 5 patches.
> > > See the list archives for an explanation.
> >
> > Any particular reference for nacking 5/5?
> >
> > While I respectfully disagree with you Re: 1-4 I can't make you take it.
>
> You could prove that those are correct:
>
> make the function you're going to use an inline, compile &
> objdump/md5sum, apply the patch conversion, compile & objdump/md5sum &
> compare, make function out of line again
At this point I'll let sleeping dogs lie, it's not worth fighting over.
Harvey
next prev parent reply other threads:[~2008-05-14 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 18:56 [PATCH 5/5] b43: move the register write into radio2050_rfover_val Harvey Harrison
2008-05-14 19:22 ` Michael Buesch
2008-05-14 19:35 ` Harvey Harrison
2008-05-14 20:00 ` Johannes Berg
2008-05-14 21:53 ` Harvey Harrison [this message]
2008-05-14 20:06 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210801981.6191.44.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.