All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: PS3: Fix memory hotplug
Date: Wed, 14 May 2008 23:51:29 -0700	[thread overview]
Message-ID: <1210834289.8297.85.camel@pasglop> (raw)
In-Reply-To: <1210834125.8297.80.camel@pasglop>


> Paul, any thoughts here ? Should we add a lock ? That would mean being
> careful as the LMB stuff can be called very early, and spinlock wants
> things like PACA and possibly lockdep to be around.. 

Actually, we call early_init_devtree(), which populates the LMB, after
we initialize the PACA and lockdep, so it -should- be safe to add a
spinlock.

Dave ? Any objection to adding a spinlock to the LMB code ?

Cheers,
Ben.

  reply	other threads:[~2008-05-15  6:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 16:23 PS3: Fix memory hotplug Geoff Levand
2008-05-15  6:48 ` Benjamin Herrenschmidt
2008-05-15  6:51   ` Benjamin Herrenschmidt [this message]
2008-05-15  7:02     ` David Miller
2008-05-20  0:40       ` [rfc] [patch] LMB: Add basic spin locking to lmb Geoff Levand
2008-05-20  0:40         ` Geoff Levand
2008-05-20  0:55         ` [patch v2] " Geoff Levand
2008-05-20  0:55           ` Geoff Levand
2008-05-20  2:22           ` David Miller
2008-05-20  2:22             ` David Miller
2008-05-20  2:32             ` Benjamin Herrenschmidt
2008-05-20  2:32               ` Benjamin Herrenschmidt
2008-05-20  2:34               ` David Miller
2008-05-20  2:34                 ` David Miller
2008-05-15  9:38   ` PS3: Fix memory hotplug Paul Mackerras
2008-05-21 18:31     ` Geoff Levand
2008-05-15 20:09 ` [patch v2] " Geoff Levand
2008-05-21 16:41   ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1210834289.8297.85.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=geoffrey.levand@am.sony.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.