From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jx4GV-000842-JT for mharc-grub-devel@gnu.org; Fri, 16 May 2008 14:02:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jx4GU-00082Y-7B for grub-devel@gnu.org; Fri, 16 May 2008 14:02:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jx4GS-00080D-7T for grub-devel@gnu.org; Fri, 16 May 2008 14:02:45 -0400 Received: from [199.232.76.173] (port=37352 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jx4GR-0007zz-UP for grub-devel@gnu.org; Fri, 16 May 2008 14:02:44 -0400 Received: from c60.cesmail.net ([216.154.195.49]:21626) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1Jx4GR-00056P-FU for grub-devel@gnu.org; Fri, 16 May 2008 14:02:43 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 16 May 2008 14:02:41 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 8F325619058 for ; Fri, 16 May 2008 14:02:41 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <3ac92b10805161048q6b4e12b4kd8cca66644d904a9@mail.gmail.com> References: <200805080454.54578.isaacmarcos100010@gmail.com> <200805091213.27785.isaacmarcos100010@gmail.com> <1210366588.14815.11.camel@dv> <200805120915.01236.isaacmarcos100010@gmail.com> <1210891552.2360.35.camel@dv> <3ac92b10805161048q6b4e12b4kd8cca66644d904a9@mail.gmail.com> Content-Type: text/plain Date: Fri, 16 May 2008 14:02:40 -0400 Message-Id: <1210960960.19414.6.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub-probe gets a segfault X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 May 2008 18:02:46 -0000 On Sat, 2008-05-17 at 13:18 +0000, Isaac Marcos wrote: > The fix would be to reject RAID partitions in > grub_lvm_scan_device(). > The only validity check in that function is presence of the > LVM label in > the first 4 sectors. Perhaps additional checks are needed. > Good find Pavel. :-) > > Just a question, /dev/sda5 has an equivalent setup: > # pvck /dev/sda5 > Device /dev/sda5 not found (or ignored by filtering). > /dev/sda5 232 3396 25422831 fd Linux raid > autodetect > > Why grub-probe doesn't fail on /dev/sda5? I think because it has no LVM label. Maybe /dev/sda6 was holding a LVM physical volume before, and the label was not erased when it became a RAID partition. As you can see, pvck doesn't display information partition. It means it cannot be fooled by the label. And that's what GRUB should do. -- Regards, Pavel Roskin