Re: [RFC-PATCH] mac80211: add helpers for frame control tests

[Harvey Harrison <harvey.harrison@gmail.com>]

On Sat, 2008-05-17 at 00:03 +0200, Johannes Berg wrote:
> On Fri, 2008-05-16 at 14:57 -0700, Harvey Harrison wrote:
> > On Fri, 2008-05-16 at 23:12 +0200, Johannes Berg wrote:
> > > 
> > > Right. Still, I think it should be named with _is_ in there.
> > 
> > Yes, I agree with you, that's what I meant to write.
> 
> Actually, maybe it should be "has" and not "is" since it's being passed
> a frame that can *have* a given frame type, and is a frame of a given
> type. Dunno.

I think _is_ works best, I'll send out a few trial patches, but this
seems to make sense in the places its used.

> 
> > Ahhh, I see what you are getting at now, how about ieee80211_stype_mask?
> > 
> > That makes the & a little clearer and has better semantic meaning.
> > 
> > The other option is still to call it stype_mask, but change it to
> > return a __le16....so tests against != 0 still work and really
> > is just a wrapper around the byteswap of the constant and the &.
> 
> Hmm. I'm not sure, how is all this really used? It seems you want
> 
> ieee80211_has_qos_stype(hdr)
> and
> 
> ieee80211_has_stype(hdr, stype)
> 
> instead, no?

Just the latter I think.  But I'll do a few patches to see how it looks
first.  If there end up being a few common ones (like qos) a few
short-hand versions might be appropriate, I'll see how it goes.

Harvey