Re: iwlwifi injection bug

[Zhu Yi <yi.zhu@intel.com>]

On Fri, 2008-05-16 at 15:47 +0200, Johannes Berg wrote:
> I don't know why you want to disallow sending frames when in monitor
> mode (especially since reportedly it works), but this is not a good
> way
> to go about it:
> 
> static int iwl4965_mac_tx(struct ieee80211_hw *hw, struct sk_buff
> *skb)
> {
>         struct iwl_priv *priv = hw->priv;
> 
>         IWL_DEBUG_MAC80211("enter\n");
> 
>         if (priv->iw_mode == IEEE80211_IF_TYPE_MNTR) {
>                 IWL_DEBUG_MAC80211("leave - monitor\n");
>                 return -1;
>         }
> 
> You see, this will cause mac80211 to resubmit the frame and most
> likely will totally mess up queue handling and various other things.

The monitor mode the driver is using currently is purely a "sniffer". We
will look into other promiscuous mode supported by the firmware to see
if we can enable that.

Thanks,
-yi