All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/21] drivers/usb: use aligned-endian get/put helpers
Date: Tue, 20 May 2008 11:45:53 -0700	[thread overview]
Message-ID: <1211309154.5915.189.camel@brick> (raw)
In-Reply-To: <1211306772.5915.173.camel@brick>

On Tue, 2008-05-20 at 11:06 -0700, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---

After all that I compiled with the wrong config to make sure
it all compiled after splitting, extra bracket in devio.c

>  drivers/usb/c67x00/c67x00-hcd.c |    4 ++--
>  drivers/usb/core/devio.c        |   12 ++++++------
>  drivers/usb/gadget/net2280.c    |    2 +-
>  drivers/usb/host/ehci.h         |    6 ++----
>  drivers/usb/host/isp116x-hcd.c  |    4 ++--
>  drivers/usb/host/ohci.h         |   16 ++++++----------
>  drivers/usb/host/uhci-hub.c     |    6 +++---
>  drivers/usb/misc/auerswald.c    |    2 +-
>  drivers/usb/serial/garmin_gps.c |    9 ++++-----
>  drivers/usb/storage/isd200.c    |    4 ++--
>  10 files changed, 29 insertions(+), 36 deletions(-)
>  
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index de17738..b44a061 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -993,18 +993,18 @@ static int proc_do_submiturb(struct dev_state *ps, struct usbdevfs_urb *uurb,
>  			kfree(dr);
>  			return -EFAULT;
>  		}
> -		if (uurb->buffer_length < (le16_to_cpup(&dr->wLength) + 8)) {
> +		if (uurb->buffer_length < get_le16(&dr->wLength) + 8)) {
								      ^
Sorry.

Harvey


      reply	other threads:[~2008-05-20 18:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20 18:06 [PATCH 05/21] drivers/usb: use aligned-endian get/put helpers Harvey Harrison
2008-05-20 18:45 ` Harvey Harrison [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211309154.5915.189.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.