Re: [PATCH 3/8] SUNRPC: Use RPC procedure name in call_verify

[Trond Myklebust <Trond.Myklebust@netapp.com>]

On Tue, 2008-05-20 at 16:29 -0400, Chuck Lever wrote:
> Making debugging output a little cleaner in call_verify by displaying the
> name of the RPC procedure instead of it's number.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
>  net/sunrpc/clnt.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index adbc85c..5aa32fa 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -1431,10 +1431,10 @@ call_verify(struct rpc_task *task)
>  		error = -EPROTONOSUPPORT;
>  		goto out_err;
>  	case RPC_PROC_UNAVAIL:
> -		dprintk("RPC: %5u %s: proc %p unsupported by program %u, "
> +		dprintk("RPC: %5u %s: proc %s unsupported by program %u, "
>  				"version %u on server %s\n",
>  				task->tk_pid, __func__,
> -				task->tk_msg.rpc_proc,
> +				task->tk_msg.rpc_proc->p_name,
>  				task->tk_client->cl_prog,
>  				task->tk_client->cl_vers,
>  				task->tk_client->cl_server);

This will cause a crash if you ever call it while somebody is calling
rpc_call_null. There may be other cases too.


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com