Re: [PATCH] Make acpi-cpufreq more robust against BIOS freq changes behind our back

[Thomas Renninger <trenn@suse.de>]

On Wed, 2008-05-21 at 15:08 +0200, Thomas Renninger wrote:
> Hi,
> 
> Please consider this one for stable integration.
...
> If this one patches for you for 2.6.24.4 also, maybe it even gets in
> there.
Hmm, I added this to OpenSUSE 10.3, means 2.6.22.
I only had to adjust the arch/i386 vs arch/x86 patch.
If this gets into the stable kernel, I wonder how far back this makes
sense. Shall I send a 2.6.22 based version?

   Thomas
> 
> ------------
> 
> commit e56a727b023d40d1adf660168883f30f2e6abe0a
> Author: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> Date:   Mon Apr 28 15:13:43 2008 -0400
> 
>     [CPUFREQ] Make acpi-cpufreq more robust against BIOS freq changes behind our back.
>     
>     We checked the hardware freq with OS cached freq value in get_cur_freqon_cpu().
>     
>     Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>     Signed-off-by: Thomas Renninger <trenn@suse.de>
>     Signed-off-by: Dave Jones <davej@redhat.com>
> 
> diff --git a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> index e2d870d..8db8f73 100644
> --- a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> +++ b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> @@ -339,6 +339,7 @@ static unsigned int get_cur_freq_on_cpu(unsigned int cpu)
>  {
>  	struct acpi_cpufreq_data *data = per_cpu(drv_data, cpu);
>  	unsigned int freq;
> +	unsigned int cached_freq;
>  
>  	dprintk("get_cur_freq_on_cpu (%d)\n", cpu);
>  
> @@ -347,7 +348,16 @@ static unsigned int get_cur_freq_on_cpu(unsigned int cpu)
>  		return 0;
>  	}
>  
> +	cached_freq = data->freq_table[data->acpi_data->state].frequency;
>  	freq = extract_freq(get_cur_val(&cpumask_of_cpu(cpu)), data);
> +	if (freq != cached_freq) {
> +		/*
> +		 * The dreaded BIOS frequency change behind our back.
> +		 * Force set the frequency on next target call.
> +		 */
> +		data->resume = 1;
> +	}
> +
>  	dprintk("cur freq = %u\n", freq);
>  
>  	return freq;
> 
> 
> 
> _______________________________________________
> Cpufreq mailing list
> Cpufreq@lists.linux.org.uk
> http://lists.linux.org.uk/mailman/listinfo/cpufreq