From: Martin Willi <martin@strongswan.org>
To: herbert@gondor.apana.org.au
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.26-rc3] xfrm: Installing NULL encryption IPSec SAs fails
Date: Wed, 21 May 2008 11:55:06 -0500 [thread overview]
Message-ID: <1211388907.26331.10.camel@martin> (raw)
Installing NULL encryption IPSec SAs works using the .compat name
"cipher_null", but fails with the .name "ecp(cipher_null)" due the
missing check in key length verification.
Signed-off-by: Martin Willi <martin@strongswan.org>
--- a/net/xfrm/xfrm_user.c 2008-05-21 11:34:56.000000000 -0500
+++ b/net/xfrm/xfrm_user.c 2008-05-21 11:20:08.000000000 -0500
@@ -57,6 +57,7 @@
case XFRMA_ALG_CRYPT:
if (!algp->alg_key_len &&
+ strcmp(algp->alg_name, "ecb(cipher_null)") != 0 &&
strcmp(algp->alg_name, "cipher_null") != 0)
return -EINVAL;
break;
next reply other threads:[~2008-05-21 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 16:55 Martin Willi [this message]
2008-05-21 20:37 ` [PATCH 2.6.26-rc3] xfrm: Installing NULL encryption IPSec SAs fails David Miller
2008-05-21 23:59 ` Herbert Xu
2008-05-22 0:23 ` David Miller
2008-05-22 0:30 ` Herbert Xu
2008-05-22 0:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211388907.26331.10.camel@martin \
--to=martin@strongswan.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.