From: Matt Mackall <mpm@selenic.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org, clameter@sgi.com,
lethal@linux-sh.org, dhowells@redhat.com
Subject: Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page allocator pass-through
Date: Wed, 21 May 2008 14:07:20 -0500 [thread overview]
Message-ID: <1211396840.18026.276.camel@calx> (raw)
In-Reply-To: <Pine.LNX.4.64.0805212125570.22291@sbz-30.cs.Helsinki.FI>
On Wed, 2008-05-21 at 21:26 +0300, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> This patch re-uses the PG_slab flag for marking SLOB bigblock pages so we can
> check that the pointer passed ksize() was really allocated by SLOB.
Ok, first, BUG_ON is wrong.
We already know users (ie nommu memory usage reporting) are abusing this
interface. Making them blow up is unnecessary. Just give them wrong
answers. Issuing a warning might be a good idea for debugging.
Second, I'd prefer to keep this sort of debugging code out of SLOB.
SLUB is much better suited to debugging allocator abuse.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2008-05-21 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 18:26 [RFC/PATCH 3/3] SLOB: make ksize() more strict for page allocator pass-through Pekka J Enberg
2008-05-21 19:07 ` Matt Mackall [this message]
2008-05-21 19:11 ` Pekka Enberg
2008-05-21 21:12 ` Christoph Lameter
2008-05-21 21:13 ` Pekka Enberg
2008-05-21 21:16 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211396840.18026.276.camel@calx \
--to=mpm@selenic.com \
--cc=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.