From: Daniel Walker <dwalker@mvista.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH] Introduce down_nowait()
Date: Thu, 22 May 2008 08:48:43 -0700 [thread overview]
Message-ID: <1211471323.18130.84.camel@localhost.localdomain> (raw)
In-Reply-To: <200805221856.23824.rusty@rustcorp.com.au>
On Thu, 2008-05-22 at 18:56 +1000, Rusty Russell wrote:
> The patches to change down_trylock to down_try touch a heap of files, which
> are also touched in other people's trees. If this patch goes upstream, those
> people rewriting that code can use down_try in their rewrite, and I can throw
> mine away.
Seems like it's too much trouble.. I mean, we're removing semaphores
anyway and down_trylock with them. I'll agree with Andrew down_trylock
removal is pretty glacial. It's cause there aren't many of them and most
of the ones I've looked at are in strange locking schemes, which makes
them difficult to remove..
I'm not against your changes, but if it's going to cause problems I'd
rather people focus on mutex_trylock instead.
Daniel
next prev parent reply other threads:[~2008-05-22 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 6:00 [PATCH] Introduce down_nowait() Rusty Russell
2008-05-21 6:29 ` Andrew Morton
2008-05-21 7:56 ` Rusty Russell
2008-05-21 17:04 ` Daniel Walker
2008-05-22 8:56 ` Rusty Russell
2008-05-22 15:48 ` Daniel Walker [this message]
2008-05-23 0:52 ` Rusty Russell
2008-05-21 8:04 ` Christoph Hellwig
2008-05-21 8:19 ` Andrew Morton
2008-05-21 12:09 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211471323.18130.84.camel@localhost.localdomain \
--to=dwalker@mvista.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.