From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/6] Allow create_branch() to return errors
Date: Thu, 29 May 2008 16:31:52 +1000 [thread overview]
Message-ID: <1212042712.8888.44.camel@pasglop> (raw)
In-Reply-To: <b5d665dc398cc0822783593ce3a2fc6b62990759.1212042061.git.michael@ellerman.id.au>
On Thu, 2008-05-29 at 16:20 +1000, Michael Ellerman wrote:
> Currently create_branch() creates a branch instruction for you, and patches
> it into the call site. In some circumstances it would be nice to be able to
> create the instruction and patch it later, and also some code might want
> to check for errors in the branch creation before doing the patching. A
> future patch will change create_branch() to check for errors.
>
> For callers that don't care, replace create_branch() with patch_branch(),
> which just creates the branch and patches it directly.
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
next prev parent reply other threads:[~2008-05-29 6:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 6:20 [PATCH 1/6] Move code patching code into arch/powerpc/lib/code-patching.c Michael Ellerman
2008-05-29 6:20 ` [PATCH 2/6] Allow create_branch() to return errors Michael Ellerman
2008-05-29 6:31 ` Benjamin Herrenschmidt [this message]
2008-06-05 3:48 ` Michael Ellerman
2008-05-29 6:20 ` [PATCH 3/6] Make create_branch() return errors if the branch target is too large Michael Ellerman
2008-05-29 6:33 ` Benjamin Herrenschmidt
2008-05-29 6:20 ` [PATCH 4/6] Add ppc_function_entry() which gets the entry point for a function Michael Ellerman
2008-05-29 6:37 ` Benjamin Herrenschmidt
2008-05-29 6:57 ` Michael Ellerman
2008-05-29 6:21 ` [PATCH 5/6] Add tests for the code patching code, and introduce checking functions Michael Ellerman
2008-05-29 6:21 ` [PATCH 6/6] Add PPC_NOP_INSTR, a hash define for the preferred nop instruction Michael Ellerman
2008-05-29 6:30 ` [PATCH 1/6] Move code patching code into arch/powerpc/lib/code-patching.c Benjamin Herrenschmidt
2008-06-19 6:15 ` Kumar Gala
2008-06-19 6:55 ` Michael Ellerman
2008-06-19 13:23 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212042712.8888.44.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.