From: Li Yang <leoli@freescale.com>
To: David Brownell <david-b@pacbell.net>
Cc: Eugene_Bordenkircher@selinc.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: BUG/OOPS: Double Lock in fsl_usb2_udc.c
Date: Thu, 29 May 2008 18:48:13 +0800 [thread overview]
Message-ID: <1212058093.5068.1.camel@Gundam> (raw)
In-Reply-To: <200805290223.39368.david-b@pacbell.net>
On Thu, 2008-05-29 at 02:23 -0700, David Brownell wrote:
> > On Wed, 28 May 2008 15:25:31 -0700 Eugene_Bordenkircher@selinc.com wrote:
> >
> > > Looking through other drivers, I have seen them releasing the lock
> > > immediately before calling disconnect(), however, without being an expert
> > > with this driver, I'm not entirely sure that is the best option here.
>
> Yeah, general policy is to drop the UDC spinlock whenever
> you call out to gadget driver code, since it may need to
> reenter for various reasons. (Though if drivers adopt some
> other locking policy that works, that should be fine too.
> Multiple locks don't seem to be needed.)
>
I will submit a patch to release the lock before calling disconnect().
- Leo
prev parent reply other threads:[~2008-05-29 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 22:25 BUG/OOPS: Double Lock in fsl_usb2_udc.c Eugene_Bordenkircher
2008-05-29 8:45 ` Andrew Morton
2008-05-29 9:23 ` David Brownell
2008-05-29 10:48 ` Li Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212058093.5068.1.camel@Gundam \
--to=leoli@freescale.com \
--cc=Eugene_Bordenkircher@selinc.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.