From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mark Lord <liml@rtr.ca>, linux-arch <linux-arch@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>,
linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 05/37] ata: use get/put_endian helpers
Date: Thu, 29 May 2008 21:14:35 -0700 [thread overview]
Message-ID: <1212120875.28403.179.camel@brick> (raw)
In-Reply-To: <20080529210859.0feee69d.akpm@linux-foundation.org>
On Thu, 2008-05-29 at 21:08 -0700, Andrew Morton wrote:
> On Thu, 29 May 2008 20:37:40 -0700 Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > On Thu, 2008-05-29 at 19:52 -0700, Andrew Morton wrote:
> > > On Thu, 29 May 2008 22:26:18 -0400 Mark Lord <liml@rtr.ca> wrote:
> > >
> > I'm flexible...although I'd probably get nailed to a cross for changing
> > it again so soon. (the unaligned versions, that is)
>
> We'll live.
>
> (I'm not a big fan of the patches, btw. It's more of an "oh groan,
> because it's there I suppose we really ought to do this" sort of thing.
> (strong objections would save me a lot of work (looks hopefully at
> inbox))).
Well in the case of the le16_to_cpu(*(__le16 *)ptr), it can be
profitable to use the le16_to_cpup..or get_le16 directly as
some arches have optimized versions of the pointer versions.
Harvey
next prev parent reply other threads:[~2008-05-30 4:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 20:18 [PATCH 05/37] ata: use get/put_endian helpers Harvey Harrison
2008-05-30 2:26 ` Mark Lord
2008-05-30 2:52 ` Andrew Morton
2008-05-30 3:37 ` Harvey Harrison
2008-05-30 4:08 ` Andrew Morton
2008-05-30 4:14 ` Harvey Harrison [this message]
2008-05-30 4:10 ` Paul Mackerras
2008-05-30 4:18 ` Harvey Harrison
2008-05-30 5:04 ` Andrew Morton
2008-05-30 13:15 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212120875.28403.179.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.