All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Michael Buesch <mb@bu3sch.de>,
	Stefano Brivio <stefano.brivio@polimi.it>,
	linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] b43legacy: Fix controller restart crash
Date: Fri, 30 May 2008 18:39:02 -0400	[thread overview]
Message-ID: <1212187142.18496.19.camel@dv> (raw)
In-Reply-To: <20080528191224.GB25770@tuxdriver.com>

On Wed, 2008-05-28 at 15:12 -0400, John W. Linville wrote:

> > Stefano, this is untested. Please test by doing
> > echo -n 1 >/debug/b43legacy/phy*/restart
> > rmmod b43legacy
> > It should not crash anymore at the rmmod (actually the restart should
> > also hang in b43legacy, as it has a deadlock, which this patch also fixes).
> 
> Anyone get a chance to test this one?

Yes, the patch is fine.

Unloading b43legacy hangs without the patch and works properly with the
patch.

-- 
Regards,
Pavel Roskin

      reply	other threads:[~2008-05-30 22:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22 15:06 [PATCH] b43legacy: Fix controller restart crash Michael Buesch
2008-05-28 19:12 ` John W. Linville
2008-05-30 22:39   ` Pavel Roskin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212187142.18496.19.camel@dv \
    --to=proski@gnu.org \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=stefano.brivio@polimi.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.