diff for duplicates of <1212252522.2766.8.camel@rd> diff --git a/a/1.txt b/N1/1.txt index 4ca2306..6bb31ae 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,10 @@ Hello! You beat me at reporting it. I was about to report the same thing. -Basically, my laptop with bcm4311 started crashing when using WEP in th= -e +Basically, my laptop with bcm4311 started crashing when using WEP in the last weeks. Its runs the current wireless-testing. -On Sat, 2008-05-31 at 16:23 +0200, Stefanik G=E1bor wrote: +On Sat, 2008-05-31 at 16:23 +0200, Stefanik Gábor wrote: > #4 [c04619c8] b43_generate_txhdr at f8dd3a99 Yes, that's where it happens. This patch prevents the panic, but it's @@ -17,22 +16,22 @@ index f9e1cff..5ec8d86 100644 --- a/drivers/net/wireless/b43/xmit.c +++ b/drivers/net/wireless/b43/xmit.c @@ -234,11 +234,14 @@ int b43_generate_txhdr(struct b43_wldev *dev, -=20 - plcp_fragment_len =3D fragment_len + FCS_LEN; + + plcp_fragment_len = fragment_len + FCS_LEN; if (use_encryption) { -- u8 key_idx =3D info->control.hw_key->hw_key_idx; +- u8 key_idx = info->control.hw_key->hw_key_idx; + u8 key_idx; struct b43_key *key; int wlhdr_len; size_t iv_len; -=20 + + if (!info->control.hw_key) + return -ENOKEY; -+ key_idx =3D info->control.hw_key->hw_key_idx; - B43_WARN_ON(key_idx >=3D dev->max_nr_keys); - key =3D &(dev->key[key_idx]); -=20 -Another workaround is to use nohwcrypt=3D1 in the module options. ++ key_idx = info->control.hw_key->hw_key_idx; + B43_WARN_ON(key_idx >= dev->max_nr_keys); + key = &(dev->key[key_idx]); + +Another workaround is to use nohwcrypt=1 in the module options. It's strange that other drivers (b43legacy, ath5k) use info->control.hw_key->hw_key_idx under the same conditions (see how @@ -44,11 +43,6 @@ recognize many networks, some of which are with WPA). I don't know if it's relevant. It's Fedora 9 for x86_64, but NetworkManager is disabled. ---=20 +-- Regards, Pavel Roskin --- -To unsubscribe from this list: send the line "unsubscribe linux-wireles= -s" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index c9e60b8..ed904c4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -11,11 +11,10 @@ "Hello!\n" "\n" "You beat me at reporting it. I was about to report the same thing.\n" - "Basically, my laptop with bcm4311 started crashing when using WEP in th=\n" - "e\n" + "Basically, my laptop with bcm4311 started crashing when using WEP in the\n" "last weeks. Its runs the current wireless-testing.\n" "\n" - "On Sat, 2008-05-31 at 16:23 +0200, Stefanik G=E1bor wrote:\n" + "On Sat, 2008-05-31 at 16:23 +0200, Stefanik G\303\241bor wrote:\n" "> #4 [c04619c8] b43_generate_txhdr at f8dd3a99\n" "\n" "Yes, that's where it happens. This patch prevents the panic, but it's\n" @@ -27,22 +26,22 @@ "--- a/drivers/net/wireless/b43/xmit.c\n" "+++ b/drivers/net/wireless/b43/xmit.c\n" "@@ -234,11 +234,14 @@ int b43_generate_txhdr(struct b43_wldev *dev,\n" - "=20\n" - " \tplcp_fragment_len =3D fragment_len + FCS_LEN;\n" + " \n" + " \tplcp_fragment_len = fragment_len + FCS_LEN;\n" " \tif (use_encryption) {\n" - "-\t\tu8 key_idx =3D info->control.hw_key->hw_key_idx;\n" + "-\t\tu8 key_idx = info->control.hw_key->hw_key_idx;\n" "+\t\tu8 key_idx;\n" " \t\tstruct b43_key *key;\n" " \t\tint wlhdr_len;\n" " \t\tsize_t iv_len;\n" - "=20\n" + " \n" "+\t\tif (!info->control.hw_key)\n" "+\t\t\treturn -ENOKEY;\n" - "+\t\tkey_idx =3D info->control.hw_key->hw_key_idx;\n" - " \t\tB43_WARN_ON(key_idx >=3D dev->max_nr_keys);\n" - " \t\tkey =3D &(dev->key[key_idx]);\n" - "=20\n" - "Another workaround is to use nohwcrypt=3D1 in the module options.\n" + "+\t\tkey_idx = info->control.hw_key->hw_key_idx;\n" + " \t\tB43_WARN_ON(key_idx >= dev->max_nr_keys);\n" + " \t\tkey = &(dev->key[key_idx]);\n" + " \n" + "Another workaround is to use nohwcrypt=1 in the module options.\n" "\n" "It's strange that other drivers (b43legacy, ath5k) use\n" "info->control.hw_key->hw_key_idx under the same conditions (see how\n" @@ -54,13 +53,8 @@ "it's relevant. It's Fedora 9 for x86_64, but NetworkManager is\n" "disabled.\n" "\n" - "--=20\n" + "-- \n" "Regards,\n" - "Pavel Roskin\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-wireles=\n" - "s\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Pavel Roskin -07dd470e3d6e11528ed68058decb3c842bf0feef77cc889ade655d9e85d89539 +a16552aa33cfaa4840b30bdf3467c697c42e57723dc452e5b41ebcb999e037d5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.