From: Mingming Cao <cmm@us.ibm.com>
To: Theodore Tso <tytso@mit.edu>, akpm@linux-foundation.org
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Shen Feng <shen@cn.fujitsu.com>,
Akira Fujita <a-fujita@rs.jp.nec.com>
Subject: [PATCH]ext4: Fix ext4_mb_init_cache return error
Date: Sun, 01 Jun 2008 14:02:26 -0700 [thread overview]
Message-ID: <1212354146.4368.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1212173573.8596.84.camel@BVR-FS.beaverton.ibm.com>
ext4: Fix ext4_mb_init_cache return error
From: Mingming Cao <cmm@us.ibm.com>
ext4_mb_init_cache() incorrectly always return EIO on success. This
causes the caller of ext4_mb_init_cache() fail when it checks
the return value.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
---
fs/ext4/mballoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.26-rc4/fs/ext4/mballoc.c
===================================================================
--- linux-2.6.26-rc4.orig/fs/ext4/mballoc.c 2008-06-01 12:55:19.000000000 -0700
+++ linux-2.6.26-rc4/fs/ext4/mballoc.c 2008-06-01 12:55:23.000000000 -0700
@@ -798,7 +798,7 @@ static int ext4_mb_init_cache(struct pag
for (i = 0; i < groups_per_page && bh[i]; i++)
wait_on_buffer(bh[i]);
- err = -EIO;
+ err = 0;
for (i = 0; i < groups_per_page && bh[i]; i++)
if (!buffer_uptodate(bh[i]))
goto out;
next prev parent reply other threads:[~2008-06-01 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 11:17 [RFC][PATCH 0/8]ext4: online defrag (ver 0.9) Akira Fujita
2008-05-30 18:52 ` Mingming
2008-06-01 21:02 ` Mingming Cao [this message]
2008-06-02 1:16 ` [PATCH]ext4: Fix ext4_mb_init_cache return error Shen Feng
2008-06-02 2:27 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212354146.4368.3.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=a-fujita@rs.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shen@cn.fujitsu.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.