All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2] Fix ordering of args for list_add
Date: Mon, 02 Jun 2008 15:43:41 +0100	[thread overview]
Message-ID: <1212417821.3474.76.camel@quoit> (raw)

From 9b6a76f99b73875150eaee554f1dbac5702d4e83 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Mon, 2 Jun 2008 09:08:47 +0100
Subject: [PATCH] [GFS2] Fix ordering of args for list_add

The patch to remove lock_nolock managed to get the arguments
of this list_add backwards. This fixes it.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/locking.c b/fs/gfs2/locking.c
index a4a367a..523243a 100644
--- a/fs/gfs2/locking.c
+++ b/fs/gfs2/locking.c
@@ -163,7 +163,7 @@ retry:
 	mutex_lock(&lmh_lock);
 
 	if (list_empty(&nolock_proto.lw_list))
-		list_add(&lmh_list, &nolock_proto.lw_list);
+		list_add(&nolock_proto.lw_list, &lmh_list);
 
 	found = 0;
 	list_for_each_entry(lw, &lmh_list, lw_list) {
-- 
1.5.1.2





                 reply	other threads:[~2008-06-02 14:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212417821.3474.76.camel@quoit \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.