All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@hp.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] ide: fix ATAPI read drive structure command (v3)
Date: Wed, 04 Jun 2008 08:49:35 -0600	[thread overview]
Message-ID: <1212590975.6711.8.camel@lappy> (raw)
In-Reply-To: <4846A83B.2050000@us.ibm.com>

On Wed, 2008-06-04 at 09:35 -0500, Anthony Liguori wrote:
> I think the automatic probing is good, but we should have a -drive 
> parameter that allows the cd type to explicitly be set to either CDROM 
> or DVD.  This can be done in a follow-up patch though.  I did some 
> testing with Windows and this patch seems to do the right thing.

It seems like both places the check is used we're concerned about the
type of media inserted.  I don't know enough about ISO formats, but
perhaps we could identify it as iso9660 vs udf at some level.  Thanks
for the comments, review, and testing.

	Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.

      reply	other threads:[~2008-06-04 14:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-27  5:25 [Qemu-devel] [PATCH] ide: fix ATAPI read drive structure command Alex Williamson
2008-05-27  7:46 ` Alexander Graf
2008-05-28 19:48   ` Alex Williamson
2008-06-02 10:33     ` Alexander Graf
2008-06-02 14:58       ` Alex Williamson
2008-06-02 15:42         ` Alexander Graf
2008-06-02 22:12           ` [Qemu-devel] [PATCH] ide: fix ATAPI read drive structure command (v3) Alex Williamson
2008-06-02 22:45             ` Alex Williamson
2008-06-03 13:48               ` Alexander Graf
2008-06-03 14:21                 ` Alex Williamson
2008-06-03 18:01                   ` Carlo Marcelo Arenas Belon
2008-06-03 16:59               ` Anthony Liguori
2008-06-04 12:30                 ` Alex Williamson
2008-06-04 14:35                   ` Anthony Liguori
2008-06-04 14:49                     ` Alex Williamson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212590975.6711.8.camel@lappy \
    --to=alex.williamson@hp.com \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.