From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K3wCJ-0002kW-F5 for mharc-grub-devel@gnu.org; Wed, 04 Jun 2008 12:50:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3wCH-0002kH-77 for grub-devel@gnu.org; Wed, 04 Jun 2008 12:50:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3wCF-0002jx-Qv for grub-devel@gnu.org; Wed, 04 Jun 2008 12:50:48 -0400 Received: from [199.232.76.173] (port=56343 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3wCF-0002ju-NR for grub-devel@gnu.org; Wed, 04 Jun 2008 12:50:47 -0400 Received: from c60.cesmail.net ([216.154.195.49]:18703) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1K3w35-0004Gv-8I for grub-devel@gnu.org; Wed, 04 Jun 2008 12:41:19 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 04 Jun 2008 12:41:16 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id D675F619058 for ; Wed, 4 Jun 2008 12:41:15 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080604120757.GA23648@thorin> References: <20080602135014.GA4563@thorin> <1212415910.3659.0.camel@rd> <20080603211257.GB10712@thorin> <1212530631.11375.4.camel@dv> <20080604120757.GA23648@thorin> Content-Type: text/plain Date: Wed, 04 Jun 2008 12:41:14 -0400 Message-Id: <1212597674.15804.2.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] register dummy drive X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2008 16:50:49 -0000 On Wed, 2008-06-04 at 14:07 +0200, Robert Millan wrote: > On Tue, Jun 03, 2008 at 06:03:51PM -0400, Pavel Roskin wrote: > > > > > > > > > > This patch solves the problem by spliting device/drive map[] entry registration > > > > > into a separate function, and using that from grub-probe.c to register a dummy > > > > > drive that will last during the current execution. > > > > > > Part of what makes grub-probe interesting is that it shares a lot of code with > > > the freestanding GRUB you will run later, so when it is used during > > > grub-install & update-grub, it is very useful to catch possible problems. I > > > think hostfs would defeat that purpose. > > > > Well, then we probably don't want to ignore any errors. When do you > > have the situation that the drive cannot be resolved? > > For example, when the next version of Linux decides to rename all devices (it > tends to do that often) and suddenly none of them match any device.map entry. > > The thing is, for what we're trying to do (-t fs, -t fs_uuid, -t partmap) we > don't care how will GRUB identify those devices when it's running on the BIOS, > so just any string that uniquely identifies them will be enough so we can > run our filesystem / partmap probes. OK, then the "dummy drive" is not really dummy. Those in device.map are dummy :-) I'm basically fine with anything that gets rid on device.map at least for single-drive installs. -- Regards, Pavel Roskin