From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K44u1-0007go-Op for mharc-grub-devel@gnu.org; Wed, 04 Jun 2008 22:08:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K44tz-0007gD-Ta for grub-devel@gnu.org; Wed, 04 Jun 2008 22:08:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K44ty-0007fs-CD for grub-devel@gnu.org; Wed, 04 Jun 2008 22:08:31 -0400 Received: from [199.232.76.173] (port=60754 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K44ty-0007fp-98 for grub-devel@gnu.org; Wed, 04 Jun 2008 22:08:30 -0400 Received: from c60.cesmail.net ([216.154.195.49]:19873) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1K44tx-0002Wh-VQ for grub-devel@gnu.org; Wed, 04 Jun 2008 22:08:30 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 04 Jun 2008 22:08:29 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 03C37619058 for ; Wed, 4 Jun 2008 22:08:28 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080604233019.GA21645@thorin> References: <20080604233019.GA21645@thorin> Content-Type: text/plain Date: Wed, 04 Jun 2008 22:08:28 -0400 Message-Id: <1212631708.26365.26.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] missleading function name X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jun 2008 02:08:32 -0000 On Thu, 2008-06-05 at 01:30 +0200, Robert Millan wrote: > IMHO the name of this function is highly misleading. It makes one think > it just checks something, but it actually modifies our variables. I think > "adjust" would fit better than "check". But nothing can be better that a good old-fashioned connect before the function. It looks like it does several things: 1) it makes sectors disk relative from partition relative (I guess that's what grub-emu forgets) 2) it normalizes offset to be less than the sector size 3) it verifies that the range is inside the partition. -- Regards, Pavel Roskin