From: Zhao Yakui <yakui.zhao@intel.com>
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org
Subject: [PATCH] ACPI : Disable the C2C3_FFH access mode if MWAIT is unsupported
Date: Thu, 05 Jun 2008 11:44:15 +0800 [thread overview]
Message-ID: <1212637455.10730.8.camel@yakui_zhao.sh.intel.com> (raw)
Subject: ACPI: Disable the C2C3_FFH access mode if MWAIT is unsupported
From: Zhao Yakui <yakui.zhao@intel.com>
After the following commit is merged, C2C3_FFH mode will be enabled and
passed into the _PDC object. But because MWAIT is unsupported on some laptops,
the different power states will be returned by the _CST object.
Maybe it will be better to disable C2C3_FFH access mode if MWAIT is unsupported.
commit 991528d7348667924176f3e29addea0675298944
Author: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Date: Mon Sep 25 16:28:13 2006 -0700
ACPI: Processor native C-states using MWAIT
http://bugzilla.kernel.org/show_bug.cgi?id=10807
Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
Signed-off-by: Li Shaohua <shaohua.li@intel.com>
---
arch/x86/kernel/acpi/processor.c | 5 +++++
1 file changed, 5 insertions(+)
Index: linux-2.6/arch/x86/kernel/acpi/processor.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/acpi/processor.c
+++ linux-2.6/arch/x86/kernel/acpi/processor.c
@@ -43,6 +43,11 @@ static void init_intel_pdc(struct acpi_p
buf[0] = ACPI_PDC_REVISION_ID;
buf[1] = 1;
buf[2] = ACPI_PDC_C_CAPABILITY_SMP;
+ /*
+ * If mwait/monitor is unsupported, C2/C3_FFH will be disabled.
+ */
+ if (!cpu_has(c, X86_FEATURE_MWAIT))
+ buf[2] &= ~ACPI_PDC_C_C2C3_FFH;
/*
* The default of PDC_SMP_T_SWCOORD bit is set for intel x86 cpu so
next reply other threads:[~2008-06-05 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 3:44 Zhao Yakui [this message]
2008-06-05 5:35 ` [PATCH] ACPI : Disable the C2C3_FFH access mode if MWAIT is unsupported Len Brown
2008-06-05 5:45 ` Shaohua Li
-- strict thread matches above, loose matches on Subject: below --
2008-06-05 6:33 Zhao Yakui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212637455.10730.8.camel@yakui_zhao.sh.intel.com \
--to=yakui.zhao@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.