From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K4MnY-0006dE-TZ for mharc-grub-devel@gnu.org; Thu, 05 Jun 2008 17:15:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K4MnX-0006cw-36 for grub-devel@gnu.org; Thu, 05 Jun 2008 17:15:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K4MnV-0006ck-L4 for grub-devel@gnu.org; Thu, 05 Jun 2008 17:15:02 -0400 Received: from [199.232.76.173] (port=48317 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K4MnV-0006ce-Hb for grub-devel@gnu.org; Thu, 05 Jun 2008 17:15:01 -0400 Received: from c60.cesmail.net ([216.154.195.49]:13915) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1K4MnV-0004fm-Bi for grub-devel@gnu.org; Thu, 05 Jun 2008 17:15:01 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 05 Jun 2008 17:14:59 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 2EC24619058 for ; Thu, 5 Jun 2008 17:15:00 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080605211115.GB13515@thorin> References: <20080604233019.GA21645@thorin> <1212631708.26365.26.camel@dv> <20080605211115.GB13515@thorin> Content-Type: text/plain Date: Thu, 05 Jun 2008 17:14:59 -0400 Message-Id: <1212700499.30431.8.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] missleading function name X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jun 2008 21:15:03 -0000 On Thu, 2008-06-05 at 23:11 +0200, Robert Millan wrote: > On Wed, Jun 04, 2008 at 10:08:28PM -0400, Pavel Roskin wrote: > > On Thu, 2008-06-05 at 01:30 +0200, Robert Millan wrote: > > > IMHO the name of this function is highly misleading. It makes one think > > > it just checks something, but it actually modifies our variables. I think > > > "adjust" would fit better than "check". > > > > But nothing can be better that a good old-fashioned connect before the > > function. > > What do you mean? I mean "comment", sorry. -- Regards, Pavel Roskin