From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K5FL3-00032i-8O for mharc-grub-devel@gnu.org; Sun, 08 Jun 2008 03:29:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K5FL2-00032b-9p for grub-devel@gnu.org; Sun, 08 Jun 2008 03:29:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K5FL0-000313-IP for grub-devel@gnu.org; Sun, 08 Jun 2008 03:29:15 -0400 Received: from [199.232.76.173] (port=37743 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K5FL0-000310-Em for grub-devel@gnu.org; Sun, 08 Jun 2008 03:29:14 -0400 Received: from mx20.gnu.org ([199.232.41.8]:57298) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K5FKz-0000QE-UM for grub-devel@gnu.org; Sun, 08 Jun 2008 03:29:14 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K5FKz-0003U1-Aw for grub-devel@gnu.org; Sun, 08 Jun 2008 03:29:13 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 08 Jun 2008 03:29:12 -0400 Received: from [192.168.1.46] (pool-71-185-129-251.phlapa.east.verizon.net [71.185.129.251]) by relay.cesmail.net (Postfix) with ESMTP id A5A4B619058 for ; Sun, 8 Jun 2008 03:29:11 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20080604233536.GA21711@thorin> <20080606155649.GA13255@thorin> <1212792832.1893.17.camel@dv> <20080606233843.GB7956@thorin> <20080607023314.kftgc01au2o4c8sw-cebfxv@webmail.spamcop.net> <1212904845.3071.52.camel@rd> <1212907952.31548.2.camel@rd> Content-Type: text/plain Date: Sun, 08 Jun 2008 03:29:08 -0400 Message-Id: <1212910148.14564.4.camel@rd> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] biosdisk / open_device() messing up offsets X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jun 2008 07:29:16 -0000 On Sun, 2008-06-08 at 15:11 +0800, Bean wrote: > On Sun, Jun 8, 2008 at 2:52 PM, Pavel Roskin wrote: > >> > >> The reason I add device support for hexdump is to debug the nand > >> driver. I need to go around the disk cache and call the underlying > >> disk driver directly, so I use disk->dev->read. For (nand), there is > >> just one partition, so I didn't notice the problem then. > > > > Here's the patch. Everything seems to be OK. "--skip=N" is not > > recognized, but it's something in the option parsing code. "-s N" is > > working. > > > > Please feel free to apply. > > Perhaps we should keep the low level api, just fix the offset. Hexdump > is normally used for debugging, and the disk cache is quite annoying. OK, it's your choice. > btw, please try the patch, it dumps the journal information. There > could be quite some output, you can use grub-fstest to capture it. It breaks installation: # grub-install /dev/sda grub-mkimage: error: cannot stat /usr/local/lib/grub/i386-pc/header:.mod "header:" must be from the patch. I cannot generate a short image easily because loopback devices are not supported. Perhaps I'll try making a real partition initialized with zeroes or something like that. -- Regards, Pavel Roskin