From: Dave Hansen <dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Benjamin Thery <benjamin.thery-6ktuUTfB/bM@public.gmane.org>
Cc: Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH 2/2] cryo: Fix option -f in checkpointing mode
Date: Mon, 09 Jun 2008 09:16:08 -0700 [thread overview]
Message-ID: <1213028168.3508.20.camel@nimitz> (raw)
In-Reply-To: <20080609144844.524643174-4vkkeT0zb4ZEtYaxpPmRp1aPQRlvutdw@public.gmane.org>
On Mon, 2008-06-09 at 16:47 +0200, Benjamin Thery wrote:
> Option -f couldn't be used in conjunction with option -p (for
> checkpointing).
> O_CREAT is missing in the flags passed to open().
>
> Now, we can do:
>
> $ cr -p MYPID -f test.cryo
>
> (I know the coding style is not perfect (long lines, several
> instructions
> on the same line), but it fits with cryo's style :) ).
So, I suggest that we start using kernel coding style on this sucker.
We're all used to it, and the original developer isn't around to bitch
about it. :)
-- Dave
next prev parent reply other threads:[~2008-06-09 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 14:47 [PATCH 0/2] cryo: fixes for handling options -l and -f Benjamin Thery
2008-06-09 14:47 ` [PATCH 1/2] cryo: Fix option -l Benjamin Thery
2008-06-09 14:47 ` [PATCH 2/2] cryo: Fix option -f in checkpointing mode Benjamin Thery
[not found] ` <20080609144844.524643174-4vkkeT0zb4ZEtYaxpPmRp1aPQRlvutdw@public.gmane.org>
2008-06-09 16:16 ` Dave Hansen [this message]
2008-06-09 16:42 ` Serge E. Hallyn
[not found] ` <20080609164203.GB1569-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-09 16:44 ` Dave Hansen
[not found] ` <20080609144709.408752383-4vkkeT0zb4ZEtYaxpPmRp1aPQRlvutdw@public.gmane.org>
2008-06-09 16:55 ` [PATCH 0/2] cryo: fixes for handling options -l and -f Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213028168.3508.20.camel@nimitz \
--to=dave-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=benjamin.thery-6ktuUTfB/bM@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.