From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K6pc4-0004HD-T2 for mharc-grub-devel@gnu.org; Thu, 12 Jun 2008 12:25:24 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K6pc2-0004Ex-Rl for grub-devel@gnu.org; Thu, 12 Jun 2008 12:25:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K6pc0-0004CW-Rl for grub-devel@gnu.org; Thu, 12 Jun 2008 12:25:22 -0400 Received: from [199.232.76.173] (port=55096 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K6pc0-0004CG-MK for grub-devel@gnu.org; Thu, 12 Jun 2008 12:25:20 -0400 Received: from c60.cesmail.net ([216.154.195.49]:18393) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1K6pc0-0007xd-J7 for grub-devel@gnu.org; Thu, 12 Jun 2008 12:25:20 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 12 Jun 2008 12:25:19 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 4A2C4619058 for ; Thu, 12 Jun 2008 12:25:19 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20080604233536.GA21711@thorin> <1212975838.3863.35.camel@dv> <1213122389.2348.21.camel@dv> <1213138695.2345.4.camel@dv> <20080612022223.4xwra53cw0go0s8w-cebfxv@webmail.spamcop.net> Content-Type: text/plain Date: Thu, 12 Jun 2008 12:25:18 -0400 Message-Id: <1213287918.20094.4.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] biosdisk / open_device() messing up offsets X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jun 2008 16:25:23 -0000 On Thu, 2008-06-12 at 17:51 +0800, Bean wrote: > The call in grub_ext2_read_inode should be ok, blkoff would limit the > read access to within a block. You are right. Now that we have grub_fshelp_read(), we don't need that code, so I'm removing it. The block normalization should be done in one place. > Seems fine to me. Committed. > grub_ext3_get_journal still have some issue, but I > can fix it after you commit it. Please go ahead. And please take care of reiserfs if you can. -- Regards, Pavel Roskin