From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K6tS6-00005f-Bv for mharc-grub-devel@gnu.org; Thu, 12 Jun 2008 16:31:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K6tS4-0008W2-JY for grub-devel@gnu.org; Thu, 12 Jun 2008 16:31:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K6tS2-0008U0-WA for grub-devel@gnu.org; Thu, 12 Jun 2008 16:31:20 -0400 Received: from [199.232.76.173] (port=41385 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K6tS2-0008Te-HK for grub-devel@gnu.org; Thu, 12 Jun 2008 16:31:18 -0400 Received: from c60.cesmail.net ([216.154.195.49]:29751) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1K6tS2-00052n-6V for grub-devel@gnu.org; Thu, 12 Jun 2008 16:31:18 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 12 Jun 2008 16:31:15 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id DE02F619058 for ; Thu, 12 Jun 2008 16:31:16 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1213133486.1287.19.camel@localhost> References: <1213128551.1287.17.camel@localhost> <484EE2AD.5090602@nic.fi> <1213133486.1287.19.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1 Date: Thu, 12 Jun 2008 16:31:15 -0400 Message-Id: <1213302675.6690.12.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Drivemap module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jun 2008 20:31:21 -0000 On Tue, 2008-06-10 at 23:31 +0200, Javier Martín wrote: > Ok, I'm sorry and don't mean to be intrusive, I just thought the last > messages might have got lost between mail filters - it's happened to me. Here's my very superficial review. Please don't add any trailing whitespace. Line in the patch that start with a plus should not end with a space or a tab. Please avoid camelCase names, such as bpaMemInKb and retVal. Local variables should generally be short, like "ret" and "bpa_mem". Some strings are excessively long. While there may be exception of the 80 column limit, I see a 118 character long line that can be trivially wrapped. The patch add a new warning: commands/i386/pc/drivemap_int13h.S: Assembler messages: commands/i386/pc/drivemap_int13h.S:124: Warning: .space repeat count is zero, ignored I'm not sure what you meant there. I don't think using #undef is a good idea. It's better to use macro names that would never be reused accidentally and thus never need to be undefined. -- Regards, Pavel Roskin