From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K6xeW-0000vU-5v for mharc-grub-devel@gnu.org; Thu, 12 Jun 2008 21:00:28 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K6xeU-0000uu-1f for grub-devel@gnu.org; Thu, 12 Jun 2008 21:00:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K6xeS-0000u0-J5 for grub-devel@gnu.org; Thu, 12 Jun 2008 21:00:25 -0400 Received: from [199.232.76.173] (port=57442 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K6xeS-0000tx-Cq for grub-devel@gnu.org; Thu, 12 Jun 2008 21:00:24 -0400 Received: from c60.cesmail.net ([216.154.195.49]:51926) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1K6xeS-0007HK-6Q for grub-devel@gnu.org; Thu, 12 Jun 2008 21:00:24 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 12 Jun 2008 21:00:22 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 56336619058 for ; Thu, 12 Jun 2008 21:00:22 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080612155828.3d1be792@gibibit.com> References: <1213128551.1287.17.camel@localhost> <484EE2AD.5090602@nic.fi> <1213133486.1287.19.camel@localhost> <1213302675.6690.12.camel@dv> <1213310611.8288.18.camel@localhost> <20080612155828.3d1be792@gibibit.com> Content-Type: text/plain Date: Thu, 12 Jun 2008 21:00:21 -0400 Message-Id: <1213318821.20744.12.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Drivemap module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2008 01:00:26 -0000 On Thu, 2008-06-12 at 15:58 -0700, Colin D Bennett wrote: > I think Pavel meant the lines added by the patch, i.e., beginning with > a plus in the patch, not in the original source. Yes, I meant added lines. There is a lot of code that needs reformatting, but the patch shouldn't add more to that. > I highly recommend running > > indent --no-tabs Why no tabs? Tabs are heavily used in the code. GNU indent is supposed to default to GNU Coding Standards, and it uses tabs. > on your source code, as long as it doesn't cause too many spurious > changes to pre-existing code. It will. > This should take care of most formatting > inconsistencies and frees you a little but from concerning yourself > with trivial details. We can use a script to re-indent everything. Then new patches could be easily run through the same script. Otherwise, it's not going to be simple. -- Regards, Pavel Roskin