From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K6yEb-0000Rj-C5 for mharc-grub-devel@gnu.org; Thu, 12 Jun 2008 21:37:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K6yEZ-0000Rc-Km for grub-devel@gnu.org; Thu, 12 Jun 2008 21:37:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K6yEY-0000RB-3c for grub-devel@gnu.org; Thu, 12 Jun 2008 21:37:43 -0400 Received: from [199.232.76.173] (port=38427 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K6yEX-0000Qr-V8 for grub-devel@gnu.org; Thu, 12 Jun 2008 21:37:41 -0400 Received: from c60.cesmail.net ([216.154.195.49]:54980) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1K6yEX-0002IT-Jp for grub-devel@gnu.org; Thu, 12 Jun 2008 21:37:41 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 12 Jun 2008 21:37:26 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id E84B6619058 for ; Thu, 12 Jun 2008 21:37:25 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1213310611.8288.18.camel@localhost> References: <1213128551.1287.17.camel@localhost> <484EE2AD.5090602@nic.fi> <1213133486.1287.19.camel@localhost> <1213302675.6690.12.camel@dv> <1213310611.8288.18.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1 Date: Thu, 12 Jun 2008 21:37:24 -0400 Message-Id: <1213321044.20744.22.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Drivemap module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2008 01:37:44 -0000 On Fri, 2008-06-13 at 00:43 +0200, Javier Martín wrote: > El jue, 12-06-2008 a las 16:31 -0400, Pavel Roskin escribió: > > Please don't add any trailing whitespace. Line in the patch that start > > with a plus should not end with a space or a tab. > I could not find the line you were referring to. I could only find one > line starting with a plus (in install_int13_handler), but it does not > end with a space/tab. However, I did find one trailing tab after a > comment, and removed it. I mean the lines your patch adds. > > Please avoid camelCase names, such as bpaMemInKb and retVal. Local > > variables should generally be short, like "ret" and "bpa_mem". > > > > Some strings are excessively long. While there may be exception of the > > 80 column limit, I see a 118 character long line that can be trivially > > wrapped. > Both corrected. retVal is still there. Please call it "ret", it's the traditional name of the variable to be returned. > Sorry, I work on a wide screen and, tough I tried to > uphold the 80-char line rule, I'm not used to it. I think there was a > switch in gedit to graphically display the 80-char limit, but I can't > find it now... Edit->Preferences->View->Right Margin > OOC: do you know if there is a syntax highlighting mode for gas/x86 > assembly code in gedit? Right now the program thinks the code is C, and > the only opcode it highlights is "int". Even a gas-only highlighting > (i.e. only the directives, not the opcodes) would be useful. There are some possibly useful attachments here: http://bugzilla.gnome.org/show_bug.cgi?id=152267 I hope that others will comment on the patch contents. -- Regards, Pavel Roskin