From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K6z2W-0005sb-3U for mharc-grub-devel@gnu.org; Thu, 12 Jun 2008 22:29:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K6z2T-0005ri-IP for grub-devel@gnu.org; Thu, 12 Jun 2008 22:29:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K6z2S-0005rK-NP for grub-devel@gnu.org; Thu, 12 Jun 2008 22:29:17 -0400 Received: from [199.232.76.173] (port=33193 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K6z2S-0005rC-Gd for grub-devel@gnu.org; Thu, 12 Jun 2008 22:29:16 -0400 Received: from ik-out-1112.google.com ([66.249.90.181]:18130) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K6z2S-000753-5q for grub-devel@gnu.org; Thu, 12 Jun 2008 22:29:16 -0400 Received: by ik-out-1112.google.com with SMTP id c21so2859413ika.2 for ; Thu, 12 Jun 2008 19:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=P2WtHD3I3Gkx0MjAyl1Qq0H0YNl7db1Z2+qM4R7xTu0=; b=g5Gp+vr4UULmAqDlkYPC6woEyLfNuOWCDmG9DM2LA9mvf9w7qd6DCNXzYRn/9OputE Qt99omNBzvyvGHrWQI+w5fSkA4Ab8CLrwSNNMv3Y4hXIN1UeHew/0hpPrSplMCTCr/9C j4/RfWKmdqj/CYKlOjgwH9qDthXW8XNl1CaE0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=p2udx/5GUVLc1r+VUYEIXo7Q9RguKhFswhf9ya+h1c1Z4PUFvf8iAZjT0DGQRMWqHy d/pVN3WWxZFhOwRzIffeD/IK+RYCQcYW7/q4E+KqGun07Opz+dvQ8rPhcNkd555CEn/M iFo/EQg7711fupmZutRVv2e2K0hOB/fyvWmak= Received: by 10.210.133.19 with SMTP id g19mr1987770ebd.83.1213324155057; Thu, 12 Jun 2008 19:29:15 -0700 (PDT) Received: from ?192.168.1.101? ( [213.37.137.93]) by mx.google.com with ESMTPS id p10sm3660141gvf.7.2008.06.12.19.29.12 (version=SSLv3 cipher=RC4-MD5); Thu, 12 Jun 2008 19:29:13 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <1213321044.20744.22.camel@dv> References: <1213128551.1287.17.camel@localhost> <484EE2AD.5090602@nic.fi> <1213133486.1287.19.camel@localhost> <1213302675.6690.12.camel@dv> <1213310611.8288.18.camel@localhost> <1213321044.20744.22.camel@dv> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-VfIA3x2oichEpgen+r9I" Date: Fri, 13 Jun 2008 04:29:14 +0200 Message-Id: <1213324154.8288.33.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: [PATCH] Drivemap module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2008 02:29:18 -0000 --=-VfIA3x2oichEpgen+r9I Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =EF=BB=BFEl jue, 12-06-2008 a las 21:37 -0400, Pavel Roskin escribi=C3=B3:=20 > I mean the lines your patch adds. > (...) > retVal is still there. Please call it "ret", it's the traditional name > of the variable to be returned. Ok, both of this completely corrected now thanks to Colin's script and the dear "find/replace" functionality that I miss so much when I'm handwriting. Didn't realize that retVal was in the "public" file loader.c. I also made other aesthetic changes based on the output of `indent', though it seems to distort "continuation" lines in C and completely borks assembly code. It is also overzealous wrt the 80-char line rule, breaking many lines with more than 75 chars and seriously unnerving me - particularly with its strange resetting of nested "if" blocks to the first indenting level. >=20 > > Sorry, I work on a wide screen and, tough I tried to > > uphold the 80-char line rule, I'm not used to it. I think there was a > > switch in gedit to graphically display the 80-char limit, but I can't > > find it now... >=20 > Edit->Preferences->View->Right Margin Thanks! I knew I had seen it before. >=20 > I hope that others will comment on the patch contents. =EF=BB=BFlol... So do I, because until now we've just been discussing its aesthetic aspects. I think we don't really need the (cleaned) version of the patch to discuss its functionality, so I won't waste bandwith sending updated versions of it if the only change is two tabs and one variable (unless you devs wanted to commit it right away ^^). Well, I'm going to call this a night, since it's 4:26 AM and I have an exam tomorrow... Goodbye! --=-VfIA3x2oichEpgen+r9I Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASFHbeaSl+Fbdeo72AQL0GA/+KY1/3Rz5Usnq61VB3HK9+tIFpSrkP/DA PV3W4KVEUhWhVtDn3spwPmm2497tUYjEqFICRmn+jEyLQz/wbbFb7f/9GKwQ8j2L TMCJiz6kPdBM1Zl/wgeqqrjq4J+/wXiyL3fF090911Ek7CB7hgoUbTXypl0xs4hu ZcwrtcWv/Xmr5KxWhAdrFBVqJbjYfTVbL7aWMOrAxQStNTVeSBAH4f7YGBPKW3PC Ri1MnZyUWrkUYoP4Mp2wOQqdjwM+eQYNzAVPYCf+kPzMYdUSNzM3A0/dEwWwb06W zy3fk3J0Xvhw3UWyHdE3dC4OJC+3g9eHH5MQ7bxcovMtIomQM8NqGUZa4iYbo1h7 ZYS0v5WnxpwVpwMTWvvsGEujY300IBa91xbuh/x+yHTQcnCiUJOyGzrNZONpovA0 wOjR0VUe4ubHfMvLRqKJFEy6ObhdYhDD6K3ie+iU3aKtpW9rVftJ2xTWAIY3SyOJ krTxR/ZoxsiGmUyITNUULNdON9eGPho334EZTF6qaTpBeWbcN7asd1ZYec7Pi9NG /E5f9viCIhbNZT913x9UZtb0Snc3dRZZ+XvWCz/A79IWw0K7MN+L9vz3e+c9Xfsz 8JmAI//iVLHAuwKciq0cjezXGrMcXP0Hb+sfva6aqmolW8jhv9lB64zP0bCeau3S K+9JDVvd8a0= =a5ms -----END PGP SIGNATURE----- --=-VfIA3x2oichEpgen+r9I--