Re: [PATCH 5/5] rpc: add new gssd upcall pipe

[Trond Myklebust <Trond.Myklebust@netapp.com>]

On Fri, 2008-06-13 at 18:50 -0400, J. Bruce Fields wrote:
> This adds the new text-based gss upcall.  We only allow an open from
> either the new pipe or the old one, and use the pipe_open method to
> enforce this.
> 
> If no pipes are open, we provisionally queue messages for the new pipe;
> a subsequent open of the old pipe will cause all those messages to be
> purged.
> 
> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
> ---

I'm not happy about allowing the gss_auth layer to control timeouts and
cancel upcalls either: that caused us way too much grief and bugs in
earlier revisions of rpc_pipefs.

Why not rather disallow queueing (i.e. put the task to sleep, and maybe
print out a reminder on the console every minute or so) until you are
notified by the rpc_pipefs layer that someone has opened the file for
reading?

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com