All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Daniel K." <dk@uw.no>
Cc: mingo@elte.hu, menage@google.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG: NULL pointer dereference] cgroups and RT scheduling interact badly.
Date: Mon, 16 Jun 2008 12:34:07 +0200	[thread overview]
Message-ID: <1213612447.16944.99.camel@twins> (raw)
In-Reply-To: <485445AE.2010602@uw.no>

On Sun, 2008-06-15 at 00:26 +0200, Daniel K. wrote:
> I get the following on the latest Linus git tree.
> 
> Testcase:
> 
> mkdir /dev/cgroup
> mount -t cgroup -o cpu,cpuset cgroup /dev/cgroup
> 
> mkdir -p /dev/cgroup/burn/oops
> cd /dev/cgroup/burn
> 
> echo 3 > cpuset.cpus
> echo 0 > cpuset.mems
> echo 1000000 > cpu.rt_period_us
> echo 940000  > cpu.rt_runtime_us
> 
> echo 3 > oops/cpuset.cpus
> echo 0 > oops/cpuset.mems
> echo 100000 > oops/cpu.rt_period_us
> echo 4000 > oops/cpu.rt_runtime_us
> 
> echo $$ > oops/tasks
> schedtool -R -p 1 -e burnP6
> 
> And then it breaks into the pieces below, as captured by netconsole.

Excellent report, thanks!


Does the below work for you?


Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
Index: linux-2.6/kernel/sched.c
===================================================================
--- linux-2.6.orig/kernel/sched.c
+++ linux-2.6/kernel/sched.c
@@ -7784,7 +7784,6 @@ static void init_tg_rt_entry(struct task
 	else
 		rt_se->rt_rq = parent->my_q;
 
-	rt_se->rt_rq = &rq->rt;
 	rt_se->my_q = rt_rq;
 	rt_se->parent = parent;
 	INIT_LIST_HEAD(&rt_se->run_list);


  reply	other threads:[~2008-06-16 10:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-14 22:26 [BUG: NULL pointer dereference] cgroups and RT scheduling interact badly Daniel K.
2008-06-16 10:34 ` Peter Zijlstra [this message]
2008-06-16 13:14   ` Daniel K.
2008-06-16 13:51     ` Peter Zijlstra
2008-06-16 14:39       ` Peter Zijlstra
2008-06-16 15:11         ` Daniel K.
2008-06-16 15:18           ` Peter Zijlstra
2008-06-17  8:49             ` Peter Zijlstra
2008-06-17 12:25               ` Daniel K.
2008-06-17 12:46                 ` Peter Zijlstra
2008-06-17 20:01                 ` Peter Zijlstra
2008-06-17 21:03                   ` Dmitry Adamushko
2008-06-17 21:48                   ` Daniel K.
2008-06-18 11:50                     ` Peter Zijlstra
2008-06-18 13:35                       ` Daniel K.
2008-06-18 14:12                         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213612447.16944.99.camel@twins \
    --to=peterz@infradead.org \
    --cc=dk@uw.no \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.