From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0C1217BBF for ; Sat, 24 May 2025 02:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748054344; cv=none; b=gUv8LfLDEzrWJx5yUXSslxr7mcKBVPH3R8OwwmDnMn0H2FgBXTJyTIsUaWAT7CJ9A4yCHIx5GjAPXAOgpAkTjqHtgP59JDvfJLIdpG0pnHgwAVqPVf/rDONNRzxjE/O8KRCJ3fnpQKLMU8BMEmB4pVrPLQ8rBHVsEjhzlQOH+iU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748054344; c=relaxed/simple; bh=Vh18pFzKqpQe6hUFH/zjsBEjMWLf6Gf5RXVQdbysPwM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cpVAx+f4zhi+1CO8vN9TSADr40+RbWbd5+xI/U4Nfw45Icgl4uq8mBzs4APtVHY+WsyIKd85Fi0qNFteJJim1P/ODG6I1+5G4CTitbFagigI87C/QI3FXnDa9LoHVQ7UgA0pQfOh2kfZJMH51PHrirW91doXxP4Jzcy0EYWRTso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NVTaWFJr; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NVTaWFJr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748054341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rQHeLaYHvKxF+GHtQN6xMn9GC9P8oUvc+3z8s3Wst4A=; b=NVTaWFJra2J1MPGZpuxQz+NPBwrlXUiXwA7zsIv/CX2bDmVoeIGEU8vRjf5xsqXV5G2HD2 iucK/P4ezRc+gfxTRISfukErX/tKBwYZiRKq284dx3ISOeaE/H9r153Qy+ngqtEPaysCja 6/XY220XVMzKZDlxNTOivWKgc5KCHVA= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-VNRHGDwgP92u8a0OrVEmDQ-1; Fri, 23 May 2025 22:38:59 -0400 X-MC-Unique: VNRHGDwgP92u8a0OrVEmDQ-1 X-Mimecast-MFC-AGG-ID: VNRHGDwgP92u8a0OrVEmDQ_1748054339 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c5f876bfe0so71502885a.3 for ; Fri, 23 May 2025 19:38:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748054339; x=1748659139; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rQHeLaYHvKxF+GHtQN6xMn9GC9P8oUvc+3z8s3Wst4A=; b=agPRT2nL9NAknRIrytiBox+mSVBbeMPDXeSbEamKC7m2pqkHKEz9ZPGkZbkGBBmnpA 2gHnCwMFm0x+wDA1JfsDR2o8nNKfGj0yOBxi7psJ9KCITeCYv3bclX8FXcxe/XvFGk1Q tjVo/EDj8jQSRy/pMAZXuc+i4ym2X0+kRoWJIiAeqYw/j53Xa6Kgb2IXrR45o0t0wffA 12zpc0UPGP/V9M6MhuWvW7xLp4/fAsf8V8mwhBt4rbhGjw6BuQYMSR/9jxMCCj/GxKnB H9q1LuavUKAEdn1qqQHyeHrabWGI9ySVK+JnJ8OCEPg+nLXyJClADexcYLBX2z5L7xY4 JKAQ== X-Forwarded-Encrypted: i=1; AJvYcCVzsaJq/Ez5KECVv6Kk5jgyD0uzZj/abMrGaXQhYoa8yayk78Tz3AtelgNTX/5JrQZIHRd1Ln4=@lists.linux.dev X-Gm-Message-State: AOJu0YxQdRGAuIJgh+hm0PvbZKAns/o9+AfXlyGvl/nQ63GG/Cd6qb60 QV5fWk4xag0imd85GySz9U0RIY1Osy1mTBsEFtYA8cz4Az5q1PtJM3nS0eblScnpPXqsQFG/Zji J21JmtmMBr5kqnPkBxgsHlZFOHQsX2vP4CXDK0DaNdRb85FDAY1AyS70OjA== X-Gm-Gg: ASbGncsKTWI3KYDWkQ0QISH80XtKbiVi6OE4Hmgjd/mnpyzUcQ/VlEfjLUWLwjOPpUY 7UshHuMRGE0hFjFR6Vk2ZIiKLvmmp2PhOSY93J5G7vI5t65zgca94o1bw2OQ+nTVJncZqvUaTnF 6uqh9uvDlUtla7ob88i2SlM+2frTF240jrfYH1l/PwxM5uTGOes8NjJDspRG1wY7iNkIaXoNyAb 1JvY/dsJ3A/q5DT7x05W3BDqE5PQ6SUWaaYJrK9hRJF1N4aXcSb7/p5tYvJHmxyshYZwCeDfDq5 MI9PYsBR+3nd X-Received: by 2002:a05:620a:1d0d:b0:7ca:c9cb:ab1 with SMTP id af79cd13be357-7ceecbbd282mr229954585a.7.1748054339361; Fri, 23 May 2025 19:38:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErmUUHEKNy3Y7AV9txFdGa7R9r1caA7oXdVsktniXZg9N1+JC4HDh8WDXEKjBXaAJ0HK1AXg== X-Received: by 2002:a05:620a:1d0d:b0:7ca:c9cb:ab1 with SMTP id af79cd13be357-7ceecbbd282mr229952285a.7.1748054339037; Fri, 23 May 2025 19:38:59 -0700 (PDT) Received: from [192.168.40.164] ([70.105.235.240]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7cd467ef2fbsm1271523485a.59.2025.05.23.19.38.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 May 2025 19:38:58 -0700 (PDT) Message-ID: <12136dc2-41c2-45f4-b1f0-cd9d2e853e76@redhat.com> Date: Fri, 23 May 2025 22:38:52 -0400 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/5] KVM: arm64: New function to determine hardware cache management support To: Ankit Agrawal , Jason Gunthorpe , "maz@kernel.org" , "oliver.upton@linux.dev" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "ryan.roberts@arm.com" , "shahuang@redhat.com" , "lpieralisi@kernel.org" , "david@redhat.com" Cc: Aniket Agashe , Neo Jia , Kirti Wankhede , Krishnakant Jaju , "Tarun Gupta (SW-GPU)" , Vikram Sethi , Andy Currid , Alistair Popple , John Hubbard , Dan Williams , Zhi Wang , Matt Ochs , Uday Dhoke , Dheeraj Nigam , "alex.williamson@redhat.com" , "sebastianene@google.com" , "coltonlewis@google.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "ardb@kernel.org" , "akpm@linux-foundation.org" , "gshan@redhat.com" , "linux-mm@kvack.org" , "tabba@google.com" , "qperret@google.com" , "seanjc@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "maobibo@loongson.cn" References: <20250523154445.3779-1-ankita@nvidia.com> <20250523154445.3779-3-ankita@nvidia.com> <9ffc7686-0dc0-4978-8cd8-f12a1c148b63@redhat.com> <9b429da4-8db6-407e-9721-178e01fd1ebb@redhat.com> From: Donald Dutile In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wN3jK8Vke1sFRJMgTUdPfpmUrN8xrWiGYbsA8s8q9Sc_1748054339 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/23/25 9:41 PM, Ankit Agrawal wrote: >>>> +/* hardware support cache management */ >>>> +bool kvm_arch_supports_cacheable_pfnmap(void); >>> Won't this cause a build warning on non-ARM builds, b/c there is no >>> resolution of this function for the other arch's? >>> Need #ifdef or default-rtn-0 function for arch's that don't have this function? >>> >> >> ah, I see you have the weak function in patch 5/5. >> But I think you have to move that hunk to this patch, so a bisect won't cause >> a build warning (or failure, depending on how a distro sets -W in its builds). > > Thanks Donald for catching that. Fixed in v6. > Thanks for fixing the nit.