From: Mark McLoughlin <markmc@redhat.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/1] kvm: qemu: Add VIRTIO_F_NOTIFY_ON_EMPTY
Date: Wed, 18 Jun 2008 18:21:21 +0100 [thread overview]
Message-ID: <1213809681.19629.2.camel@muff> (raw)
In-Reply-To: <48590E44.2030202@qumranet.com>
On Wed, 2008-06-18 at 06:31 -0700, Avi Kivity wrote:
> Mark McLoughlin wrote:
> > Set the VIRTIO_F_NOTIFY_ON_EMPTY feature bit so the
> > guest can rely on us notifying them when the queue
> > is empty.
> >
> > Also, only notify when the available queue is empty
> > *and* when we've finished with all the buffers we
> > had detached. Right now, when the queue is empty,
> > we notify the guest for every used buffer.
> >
>
> This is a bit inflexible. I would prefer a mechanism where the guest
> tells us at what queue index it would like the notification, like Xen.
> If it wants it on queue empty, it just sets the index appropriately.
>
> Or is the usage in the drivers already upstream and I have no choice
> about applying this?
Something like that :-)
commits:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=b4f68be6c5d507afdcd74f5be3df0b1209cda503
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=363f15149cfba67d29f1e6a6103dda079f27f3fa
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=20887611523e749d99cc7d64ff6c97d27529fbae
Cheers,
Mark.
prev parent reply other threads:[~2008-06-18 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 13:16 [PATCH 1/1] kvm: qemu: Add VIRTIO_F_NOTIFY_ON_EMPTY Mark McLoughlin
2008-06-18 13:31 ` Avi Kivity
2008-06-18 17:21 ` Mark McLoughlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213809681.19629.2.camel@muff \
--to=markmc@redhat.com \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.